From ba84bc512cd99afc6eb0b2609cf2998198c92b97 Mon Sep 17 00:00:00 2001 From: Delucse <46593742+Delucse@users.noreply.github.com> Date: Thu, 17 Sep 2020 10:06:29 +0200 Subject: [PATCH 1/3] set filename to save compiled blocks --- src/actions/types.js | 1 + src/actions/workspaceActions.js | 9 ++++- src/components/Compile.js | 56 +++++++++++++++++++++++--------- src/components/WorkspaceFunc.js | 10 +++--- src/reducers/workspaceReducer.js | 10 ++++-- 5 files changed, 63 insertions(+), 23 deletions(-) diff --git a/src/actions/types.js b/src/actions/types.js index 27bd18d..a086a29 100644 --- a/src/actions/types.js +++ b/src/actions/types.js @@ -5,6 +5,7 @@ export const MOVE_BLOCK = 'MOVE_BLOCK'; export const CHANGE_BLOCK = 'CHANGE_BLOCK'; export const DELETE_BLOCK = 'DELETE_BLOCK'; export const CLEAR_STATS = 'CLEAR_STATS'; +export const NAME = 'NAME'; export const TUTORIAL_SUCCESS = 'TUTORIAL_SUCCESS'; diff --git a/src/actions/workspaceActions.js b/src/actions/workspaceActions.js index a9700c8..ab2d4e3 100644 --- a/src/actions/workspaceActions.js +++ b/src/actions/workspaceActions.js @@ -1,4 +1,4 @@ -import { NEW_CODE, CHANGE_WORKSPACE, CREATE_BLOCK, MOVE_BLOCK, CHANGE_BLOCK, DELETE_BLOCK, CLEAR_STATS } from './types'; +import { NEW_CODE, CHANGE_WORKSPACE, CREATE_BLOCK, MOVE_BLOCK, CHANGE_BLOCK, DELETE_BLOCK, CLEAR_STATS, NAME } from './types'; import * as Blockly from 'blockly/core'; @@ -72,3 +72,10 @@ export const clearStats = () => (dispatch) => { payload: stats }); }; + +export const workspaceName = (name) => (dispatch) => { + dispatch({ + type: NAME, + payload: name + }) +} diff --git a/src/components/Compile.js b/src/components/Compile.js index 8326d20..9c0894b 100644 --- a/src/components/Compile.js +++ b/src/components/Compile.js @@ -1,6 +1,7 @@ import React, { Component } from 'react'; import PropTypes from 'prop-types'; import { connect } from 'react-redux'; +import { workspaceName } from '../actions/workspaceActions'; import { withStyles } from '@material-ui/core/styles'; import Button from '@material-ui/core/Button'; @@ -12,6 +13,7 @@ import DialogActions from '@material-ui/core/DialogActions'; import Dialog from '@material-ui/core/Dialog'; import IconButton from '@material-ui/core/IconButton'; import Tooltip from '@material-ui/core/Tooltip'; +import TextField from '@material-ui/core/TextField'; import { faCogs } from "@fortawesome/free-solid-svg-icons"; import { FontAwesomeIcon } from "@fortawesome/react-fontawesome"; @@ -38,15 +40,18 @@ class Compile extends Component { state = { progress: false, - open: false + open: false, + file: false, + title: '', + content: '' } compile = () => { + this.setState({ progress: true }); const data = { "board": process.env.REACT_APP_BOARD, "sketch": this.props.arduino }; - this.setState({ progress: true }); fetch(`${process.env.REACT_APP_COMPILER_URL}/compile`, { method: "POST", headers: {'Content-Type': 'application/json'}, @@ -54,23 +59,35 @@ class Compile extends Component { }) .then(response => response.json()) .then(data => { - console.log(data) - this.download(data.data.id) + console.log(data); + this.setState({id: data.data.id}, () => { + this.createFileName(); + }); }) .catch(err => { console.log(err); - this.setState({ progress: false, open: true }); + this.setState({ progress: false, file: false, open: true, title: 'Fehler', content: 'Etwas ist beim Kompilieren schief gelaufen. Versuche es nochmal.' }); }); } - download = (id) => { - const filename = 'sketch' + download = () => { + this.toggleDialog(); + const id = this.state.id; + const filename = this.props.name; window.open(`${process.env.REACT_APP_COMPILER_URL}/download?id=${id}&board=${process.env.REACT_APP_BOARD}&filename=${filename}`, '_self'); this.setState({ progress: false }); } toggleDialog = () => { - this.setState({ open: !this.state }); + this.setState({ open: !this.state, progress: false }); + } + + createFileName = () => { + this.setState({ file: true, open: true, title: 'Blöcke kompilieren', content: 'Bitte gib einen Namen für die Bennenung des zu kompilierenden Programms ein und bestätige diesen mit einem Klick auf \'Eingabe\'.' }); + } + + setFileName = (e) => { + this.props.workspaceName(e.target.value); } render() { @@ -86,7 +103,7 @@ class Compile extends Component { : - } @@ -94,13 +111,19 @@ class Compile extends Component { - Fehler + {this.state.title} - Etwas ist beim Kompilieren schief gelaufen. Versuche es nochmal. + {this.state.content} + {this.state.file ? +
+ + +
+ : null}
@@ -110,11 +133,14 @@ class Compile extends Component { } Compile.propTypes = { - arduino: PropTypes.string.isRequired + arduino: PropTypes.string.isRequired, + name: PropTypes.string, + workspaceName: PropTypes.func.isRequired }; const mapStateToProps = state => ({ - arduino: state.workspace.code.arduino + arduino: state.workspace.code.arduino, + name: state.workspace.name }); -export default connect(mapStateToProps, null)(withStyles(styles, {withTheme: true})(Compile)); +export default connect(mapStateToProps, { workspaceName })(withStyles(styles, {withTheme: true})(Compile)); diff --git a/src/components/WorkspaceFunc.js b/src/components/WorkspaceFunc.js index c8b6ca7..ca87660 100644 --- a/src/components/WorkspaceFunc.js +++ b/src/components/WorkspaceFunc.js @@ -54,7 +54,7 @@ class WorkspaceFunc extends Component { } toggleDialog = () => { - this.setState({ open: !this.state, fileName: '', file: false }); + this.setState({ open: !this.state, fileName: '' }); } saveXmlFile = (code) => { @@ -76,7 +76,7 @@ class WorkspaceFunc extends Component { uploadXmlFile = (xmlFile) => { if(xmlFile.type !== 'text/xml'){ - this.setState({ open: true, title: 'Unzulässiger Dateityp', content: 'Die übergebene Datei entsprach nicht dem geforderten Format. Es sind nur XML-Dateien zulässig.' }); + this.setState({ open: true, file: false, title: 'Unzulässiger Dateityp', content: 'Die übergebene Datei entsprach nicht dem geforderten Format. Es sind nur XML-Dateien zulässig.' }); } else { var reader = new FileReader(); @@ -92,10 +92,10 @@ class WorkspaceFunc extends Component { Blockly.Xml.domToWorkspace(xmlDom, workspace); if(workspace.getAllBlocks().length < 1){ Blockly.Xml.domToWorkspace(Blockly.Xml.textToDom(xmlBefore), workspace) - this.setState({ open: true, title: 'Keine Blöcke', content: 'Es wurden keine Blöcke detektiert. Bitte überprüfe den XML-Code und versuche es erneut.' }); + this.setState({ open: true, file: false, title: 'Keine Blöcke', content: 'Es wurden keine Blöcke detektiert. Bitte überprüfe den XML-Code und versuche es erneut.' }); } } catch(err){ - this.setState({ open: true, title: 'Ungültige XML', content: 'Die XML-Datei konnte nicht in Blöcke zerlegt werden. Bitte überprüfe den XML-Code und versuche es erneut.' }); + this.setState({ open: true, file: false, title: 'Ungültige XML', content: 'Die XML-Datei konnte nicht in Blöcke zerlegt werden. Bitte überprüfe den XML-Code und versuche es erneut.' }); } }; } @@ -164,7 +164,7 @@ class WorkspaceFunc extends Component { diff --git a/src/reducers/workspaceReducer.js b/src/reducers/workspaceReducer.js index dc4987f..b9e3681 100644 --- a/src/reducers/workspaceReducer.js +++ b/src/reducers/workspaceReducer.js @@ -1,4 +1,4 @@ -import { CHANGE_WORKSPACE, NEW_CODE, CREATE_BLOCK, MOVE_BLOCK, CHANGE_BLOCK, DELETE_BLOCK, CLEAR_STATS } from '../actions/types'; +import { CHANGE_WORKSPACE, NEW_CODE, CREATE_BLOCK, MOVE_BLOCK, CHANGE_BLOCK, DELETE_BLOCK, CLEAR_STATS, NAME } from '../actions/types'; const initialState = { @@ -12,7 +12,8 @@ const initialState = { delete: 0, move: -1 // initialXML is moved automatically, Block is not part of the statistics }, - change: 0 + change: 0, + name: null }; export default function(state = initialState, action){ @@ -36,6 +37,11 @@ export default function(state = initialState, action){ ...state, stats: action.payload }; + case NAME: + return { + ...state, + name: action.payload + } default: return state; } From 5c43ff4648395a71130605b03328766ee58ffc7f Mon Sep 17 00:00:00 2001 From: Delucse <46593742+Delucse@users.noreply.github.com> Date: Thu, 17 Sep 2020 11:55:46 +0200 Subject: [PATCH 2/3] name of the workspace and display of its --- src/components/Compile.js | 43 +++++++++++++++------- src/components/Home.js | 8 ++-- src/components/WorkspaceFunc.js | 63 ++++++++++++++++++++++++-------- src/components/WorkspaceStats.js | 2 +- 4 files changed, 83 insertions(+), 33 deletions(-) diff --git a/src/components/Compile.js b/src/components/Compile.js index 9c0894b..f17e7c9 100644 --- a/src/components/Compile.js +++ b/src/components/Compile.js @@ -38,14 +38,25 @@ const styles = (theme) => ({ class Compile extends Component { - state = { - progress: false, - open: false, - file: false, - title: '', - content: '' + constructor(props){ + super(props); + this.state = { + progress: false, + open: false, + file: false, + title: '', + content: '', + name: props.name + }; } + componentDidUpdate(props){ + if(props.name !== this.props.name){ + this.setState({name: this.props.name}); + } + } + + compile = () => { this.setState({ progress: true }); const data = { @@ -71,9 +82,10 @@ class Compile extends Component { } download = () => { - this.toggleDialog(); const id = this.state.id; - const filename = this.props.name; + const filename = this.state.name; + this.toggleDialog(); + this.props.workspaceName(filename); window.open(`${process.env.REACT_APP_COMPILER_URL}/download?id=${id}&board=${process.env.REACT_APP_BOARD}&filename=${filename}`, '_self'); this.setState({ progress: false }); } @@ -83,11 +95,16 @@ class Compile extends Component { } createFileName = () => { - this.setState({ file: true, open: true, title: 'Blöcke kompilieren', content: 'Bitte gib einen Namen für die Bennenung des zu kompilierenden Programms ein und bestätige diesen mit einem Klick auf \'Eingabe\'.' }); + if(this.state.name){ + this.download(); + } + else{ + this.setState({ file: true, open: true, title: 'Blöcke kompilieren', content: 'Bitte gib einen Namen für die Bennenung des zu kompilierenden Programms ein und bestätige diesen mit einem Klick auf \'Eingabe\'.' }); + } } setFileName = (e) => { - this.props.workspaceName(e.target.value); + this.setState({name: e.target.value}); } render() { @@ -116,13 +133,13 @@ class Compile extends Component { {this.state.content} {this.state.file ?
- - + +
: null} - diff --git a/src/components/Home.js b/src/components/Home.js index 3da011d..1f2b6a4 100644 --- a/src/components/Home.js +++ b/src/components/Home.js @@ -1,7 +1,7 @@ import React, { Component } from 'react'; import PropTypes from 'prop-types'; import { connect } from 'react-redux'; -import { clearStats } from '../actions/workspaceActions'; +import { clearStats, workspaceName } from '../actions/workspaceActions'; import * as Blockly from 'blockly/core'; @@ -58,6 +58,7 @@ class Home extends Component { componentWillUnmount(){ this.props.clearStats(); + this.props.workspaceName(null); } onChange = () => { @@ -100,8 +101,9 @@ class Home extends Component { } Home.propTypes = { - clearStats: PropTypes.func.isRequired + clearStats: PropTypes.func.isRequired, + workspaceName: PropTypes.func.isRequired }; -export default connect(null, { clearStats })(withStyles(styles, { withTheme: true })(Home)); +export default connect(null, { clearStats, workspaceName })(withStyles(styles, { withTheme: true })(Home)); diff --git a/src/components/WorkspaceFunc.js b/src/components/WorkspaceFunc.js index ca87660..52b2006 100644 --- a/src/components/WorkspaceFunc.js +++ b/src/components/WorkspaceFunc.js @@ -1,7 +1,7 @@ import React, { Component } from 'react'; import PropTypes from 'prop-types'; import { connect } from 'react-redux'; -import { clearStats, onChangeCode } from '../actions/workspaceActions'; +import { clearStats, onChangeCode, workspaceName } from '../actions/workspaceActions'; import * as Blockly from 'blockly/core'; @@ -12,6 +12,7 @@ import { initialXml } from './Blockly/initialXml.js'; import Compile from './Compile'; import SolutionCheck from './Tutorial/SolutionCheck'; +import withWidth, { isWidthDown } from '@material-ui/core/withWidth'; import { withStyles } from '@material-ui/core/styles'; import Button from '@material-ui/core/Button'; import DialogTitle from '@material-ui/core/DialogTitle'; @@ -21,8 +22,9 @@ import Dialog from '@material-ui/core/Dialog'; import IconButton from '@material-ui/core/IconButton'; import Tooltip from '@material-ui/core/Tooltip'; import TextField from '@material-ui/core/TextField'; +import Typography from '@material-ui/core/Typography'; -import { faSave, faUpload, faShare } from "@fortawesome/free-solid-svg-icons"; +import { faPen, faSave, faUpload, faShare } from "@fortawesome/free-solid-svg-icons"; import { FontAwesomeIcon } from "@fortawesome/react-fontawesome"; const styles = (theme) => ({ @@ -35,6 +37,15 @@ const styles = (theme) => ({ backgroundColor: theme.palette.primary.main, color: theme.palette.primary.contrastText, } + }, + workspaceName: { + backgroundColor: theme.palette.secondary.main, + borderRadius: '25px', + display: 'inline-flex', + cursor: 'pointer', + '&:hover': { + color: theme.palette.primary.main, + } } }); @@ -48,30 +59,37 @@ class WorkspaceFunc extends Component { title: '', content: '', open: false, - fileName: '', - file: false + file: false, + saveXml: false, + name: props.name }; } toggleDialog = () => { - this.setState({ open: !this.state, fileName: '' }); + this.setState({ open: !this.state }); } - saveXmlFile = (code) => { + saveXmlFile = () => { + var code = this.props.xml; this.toggleDialog(); - var fileName = this.state.fileName; - if(fileName === '') fileName = 'unbekannt'; + var fileName = this.state.name; + this.props.workspaceName(fileName); fileName = `${fileName}.xml` var blob = new Blob([code], { type: 'text/xml' }); saveAs(blob, fileName); } createFileName = () => { - this.setState({ file: true, open: true, title: 'Blöcke speichern', content: 'Bitte gib einen Namen für die Bennenung der XML-Datei ein und bestätige diesen mit einem Klick auf \'Eingabe\'.' }); + if(this.state.name){ + this.saveXmlFile(); + } + else{ + this.setState({ file: true, saveXml: true, open: true, title: 'Blöcke speichern', content: 'Bitte gib einen Namen für die Bennenung der XML-Datei ein und bestätige diesen mit einem Klick auf \'Eingabe\'.' }); + } } setFileName = (e) => { - this.setState({ fileName: e.target.value }); + this.setState({name: e.target.value}); } uploadXmlFile = (xmlFile) => { @@ -116,6 +134,16 @@ class WorkspaceFunc extends Component { render() { return (
+ {!this.props.solutionCheck ? + +
{this.setState({file: true, open: true, saveXml: false, title: 'Projekt benennen', content: 'Bitte gib einen Namen für das Projekt ein und bestätige diesen mit einem Klick auf \'Eingabe\'.'})}}> + {this.props.name && !isWidthDown('xs', this.props.width) ? {this.props.name} : null} +
+ +
+
+
+ : null} {this.props.solutionCheck ? : } - - + +
: null} - @@ -176,13 +204,16 @@ class WorkspaceFunc extends Component { WorkspaceFunc.propTypes = { arduino: PropTypes.string.isRequired, xml: PropTypes.string.isRequired, + name: PropTypes.string, clearStats: PropTypes.func.isRequired, - onChangeCode: PropTypes.func.isRequired + onChangeCode: PropTypes.func.isRequired, + workspaceName: PropTypes.func.isRequired }; const mapStateToProps = state => ({ arduino: state.workspace.code.arduino, - xml: state.workspace.code.xml + xml: state.workspace.code.xml, + name: state.workspace.name }); -export default connect(mapStateToProps, { clearStats, onChangeCode })(withStyles(styles, {withTheme: true})(WorkspaceFunc)); +export default connect(mapStateToProps, { clearStats, onChangeCode, workspaceName })(withStyles(styles, {withTheme: true})(withWidth()(WorkspaceFunc))); diff --git a/src/components/WorkspaceStats.js b/src/components/WorkspaceStats.js index 32fbf1d..b072a34 100644 --- a/src/components/WorkspaceStats.js +++ b/src/components/WorkspaceStats.js @@ -50,7 +50,7 @@ class WorkspaceStats extends Component { }; render() { - const bigDisplay = !isWidthDown('xs', this.props.width); + const bigDisplay = !isWidthDown('sm', this.props.width); const workspace = Blockly.getMainWorkspace(); const remainingBlocksInfinity = workspace ? workspace.remainingCapacity() !== Infinity : null; const stats =
From c85c96468c69b4498392e5473ef469e15b5e525a Mon Sep 17 00:00:00 2001 From: Delucse <46593742+Delucse@users.noreply.github.com> Date: Thu, 17 Sep 2020 12:56:43 +0200 Subject: [PATCH 3/3] name of tutorial workspace is automatically derived from the tutorial title and the step heading --- src/components/Compile.js | 2 +- src/components/Tutorial/Assessment.js | 18 ++++++++++++++++-- src/components/Tutorial/Tutorial.js | 8 ++++++-- src/components/WorkspaceFunc.js | 15 +++++++++++++++ 4 files changed, 38 insertions(+), 5 deletions(-) diff --git a/src/components/Compile.js b/src/components/Compile.js index f17e7c9..19b35d4 100644 --- a/src/components/Compile.js +++ b/src/components/Compile.js @@ -120,7 +120,7 @@ class Compile extends Component { : - } diff --git a/src/components/Tutorial/Assessment.js b/src/components/Tutorial/Assessment.js index ead69ec..da5e7f1 100644 --- a/src/components/Tutorial/Assessment.js +++ b/src/components/Tutorial/Assessment.js @@ -1,6 +1,7 @@ import React, { Component } from 'react'; import PropTypes from 'prop-types'; import { connect } from 'react-redux'; +import { workspaceName } from '../../actions/workspaceActions'; import BlocklyWindow from '../Blockly/BlocklyWindow'; import SolutionCheck from './SolutionCheck'; @@ -14,6 +15,18 @@ import Typography from '@material-ui/core/Typography'; class Assessment extends Component { + componentDidMount(){ + // alert(this.props.name); + this.props.workspaceName(this.props.name); + } + + componentDidUpdate(props){ + if(props.name !== this.props.name){ + // alert(this.props.name); + this.props.workspaceName(this.props.name); + } + } + render() { var tutorialId = this.props.currentTutorialId; var currentTask = this.props.step; @@ -47,7 +60,8 @@ class Assessment extends Component { Assessment.propTypes = { currentTutorialId: PropTypes.number, status: PropTypes.array.isRequired, - change: PropTypes.number.isRequired + change: PropTypes.number.isRequired, + workspaceName: PropTypes.func.isRequired }; const mapStateToProps = state => ({ @@ -56,4 +70,4 @@ const mapStateToProps = state => ({ currentTutorialId: state.tutorial.currentId }); -export default connect(mapStateToProps, null)(withWidth()(Assessment)); +export default connect(mapStateToProps, { workspaceName })(withWidth()(Assessment)); diff --git a/src/components/Tutorial/Tutorial.js b/src/components/Tutorial/Tutorial.js index e2a9d38..fb4d452 100644 --- a/src/components/Tutorial/Tutorial.js +++ b/src/components/Tutorial/Tutorial.js @@ -1,6 +1,7 @@ import React, { Component } from 'react'; import PropTypes from 'prop-types'; import { connect } from 'react-redux'; +import { workspaceName } from '../../actions/workspaceActions'; import { tutorialId, tutorialStep } from '../../actions/tutorialActions'; import Breadcrumbs from '../Breadcrumbs'; @@ -29,6 +30,7 @@ class Tutorial extends Component { componentWillUnmount(){ this.props.tutorialId(null); + this.props.workspaceName(null); } render() { @@ -36,6 +38,7 @@ class Tutorial extends Component { var tutorial = tutorials.filter(tutorial => tutorial.id === currentTutorialId)[0]; var steps = tutorial ? tutorial.steps : null; var step = steps ? steps[this.props.activeStep] : null; + var name = step ? `${tutorial.title.replace(/\s/g,'')}_${step.headline.replace(/\s/g,'')}` : null; return ( !Number.isInteger(currentTutorialId) || currentTutorialId < 1 || currentTutorialId > tutorials.length ? @@ -52,7 +55,7 @@ class Tutorial extends Component { {step ? step.type === 'instruction' ? - : // if step.type === 'assessment' + : // if step.type === 'assessment' : null}
@@ -69,6 +72,7 @@ class Tutorial extends Component { Tutorial.propTypes = { tutorialId: PropTypes.func.isRequired, tutorialStep: PropTypes.func.isRequired, + workspaceName: PropTypes.func.isRequired, currentTutorialId: PropTypes.number, status: PropTypes.array.isRequired, change: PropTypes.number.isRequired, @@ -82,4 +86,4 @@ const mapStateToProps = state => ({ activeStep: state.tutorial.activeStep }); -export default connect(mapStateToProps, { tutorialId, tutorialStep })(Tutorial); +export default connect(mapStateToProps, { tutorialId, tutorialStep, workspaceName })(Tutorial); diff --git a/src/components/WorkspaceFunc.js b/src/components/WorkspaceFunc.js index 52b2006..856dea5 100644 --- a/src/components/WorkspaceFunc.js +++ b/src/components/WorkspaceFunc.js @@ -65,6 +65,12 @@ class WorkspaceFunc extends Component { }; } + componentDidUpdate(props){ + if(props.name !== this.props.name){ + this.setState({name: this.props.name}); + } + } + toggleDialog = () => { this.setState({ open: !this.state }); } @@ -112,6 +118,12 @@ class WorkspaceFunc extends Component { Blockly.Xml.domToWorkspace(Blockly.Xml.textToDom(xmlBefore), workspace) this.setState({ open: true, file: false, title: 'Keine Blöcke', content: 'Es wurden keine Blöcke detektiert. Bitte überprüfe den XML-Code und versuche es erneut.' }); } + else { + if(!this.props.solutionCheck){ + var extensionPosition = xmlFile.name.lastIndexOf('.'); + this.props.workspaceName(xmlFile.name.substr(0, extensionPosition)); + } + } } catch(err){ this.setState({ open: true, file: false, title: 'Ungültige XML', content: 'Die XML-Datei konnte nicht in Blöcke zerlegt werden. Bitte überprüfe den XML-Code und versuche es erneut.' }); } @@ -129,6 +141,9 @@ class WorkspaceFunc extends Component { workspace.options.maxBlocks = Infinity; this.props.onChangeCode(); this.props.clearStats(); + if(!this.props.solutionCheck){ + this.props.workspaceName(null); + } } render() {