From 02ddf34f2108540a6f0794246af6869ede7961e9 Mon Sep 17 00:00:00 2001 From: Pierre Vanduynslager Date: Tue, 28 Nov 2017 23:39:30 -0500 Subject: [PATCH] Fix: Remove redundant test of commitAnalyzer plugin output --- lib/get-next-version.js | 4 ---- test/get-next-version.test.js | 7 ------- 2 files changed, 11 deletions(-) diff --git a/lib/get-next-version.js b/lib/get-next-version.js index a48921b5..2d02a0fd 100644 --- a/lib/get-next-version.js +++ b/lib/get-next-version.js @@ -1,13 +1,9 @@ const semver = require('semver'); -const SemanticReleaseError = require('@semantic-release/error'); module.exports = (type, lastRelease, logger) => { let version; if (lastRelease.version) { version = semver.inc(lastRelease.version, type); - if (!version) { - throw new SemanticReleaseError(`Invalid release type ${type}`, 'EINVALIDTYPE'); - } logger.log('The next release version is %s', version); } else { version = '1.0.0'; diff --git a/test/get-next-version.test.js b/test/get-next-version.test.js index 32ea3bc1..96ccddd8 100644 --- a/test/get-next-version.test.js +++ b/test/get-next-version.test.js @@ -1,6 +1,5 @@ import test from 'ava'; import {stub} from 'sinon'; -import SemanticReleaseError from '@semantic-release/error'; import getNextVersion from '../lib/get-next-version'; test.beforeEach(t => { @@ -28,9 +27,3 @@ test('Return 1.0.0 if there is no previous release', t => { const version = getNextVersion('minor', {}, t.context.logger); t.is(version, '1.0.0'); }); - -test('Return an error if the release type is invalid', t => { - const error = t.throws(() => getNextVersion('invalid', {version: '1.0.0'}, t.context.logger)); - t.is(error.code, 'EINVALIDTYPE'); - t.true(error instanceof SemanticReleaseError); -});