simon/semantic-release
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: remove the github plugin from default success and fail hooks

Browse Source
This commit is contained in:
Pierre Vanduynslager 2018-02-13 14:27:37 -05:00
parent 1b3c51d624
commit 04f3061bed
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/definitions/plugins.js
View File

@ -47,13 +47,13 @@ module.exports = {
}, },
}, },
success: { success: {
default: ['@semantic-release/github'], default: false,
config: { config: {
validator: conf => !conf || (isArray(conf) ? conf : [conf]).every(conf => validatePluginConfig(conf)), validator: conf => !conf || (isArray(conf) ? conf : [conf]).every(conf => validatePluginConfig(conf)),
}, },
}, },
fail: { fail: {
default: ['@semantic-release/github'], default: false,
config: { config: {
validator: conf => !conf || (isArray(conf) ? conf : [conf]).every(conf => validatePluginConfig(conf)), validator: conf => !conf || (isArray(conf) ? conf : [conf]).every(conf => validatePluginConfig(conf)),
}, },

6
test/index.test.js
View File

@ -596,7 +596,7 @@ test.serial('Returns falsy value if triggered by a PR', async t => {
t.falsy(await semanticRelease({repositoryUrl})); t.falsy(await semanticRelease({repositoryUrl}));
t.is( t.is(
t.context.log.args[9][0], t.context.log.args[t.context.log.args.length - 1][0],
"This run was triggered by a pull request and therefore a new version won't be published." "This run was triggered by a pull request and therefore a new version won't be published."
); );
}); });
@ -723,8 +723,8 @@ test.serial('Hide sensitive environment variable values from the logs', async t
await t.throws(semanticRelease(options)); await t.throws(semanticRelease(options));
t.regex(t.context.stdout.args[9][0], /Console: The token \[secure\] is invalid/); t.regex(t.context.stdout.args[t.context.stdout.args.length - 2][0], /Console: The token \[secure\] is invalid/);
t.regex(t.context.stdout.args[10][0], /Log: The token \[secure\] is invalid/); t.regex(t.context.stdout.args[t.context.stdout.args.length - 1][0], /Log: The token \[secure\] is invalid/);
t.regex(t.context.stderr.args[0][0], /Error: The token \[secure\] is invalid/); t.regex(t.context.stderr.args[0][0], /Error: The token \[secure\] is invalid/);
t.regex(t.context.stderr.args[1][0], /Invalid token \[secure\]/); t.regex(t.context.stderr.args[1][0], /Invalid token \[secure\]/);
}); });