simon/semantic-release
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: use unauthenticated URL to check if branch is up to date

Browse Source 
In case the authentication token provided is unauthorized the call to `isBranchUpToDate` will fail due to lack of read permission if that URL is used. As a result the error about outdated local branch will be reported instead of the one about missing permission.
By using the original (unauthenticated) URL `isBranchUpToDate` shouldn't fail due to permission as it requires only read permissions, that are necessarly present as the CI wass able to clone the repo.
This commit is contained in:
Pierre Vanduynslager
2018-07-10 13:07:00 -04:00
parent eb22f9998d
commit 071dccea4b
3 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/git.test.js
+6 -6
View File
@@ -206,11 +206,11 @@ test.serial('Throws error if obtaining the tags fails', async t => {
});
test.serial('Return "true" if repository is up to date', async t => {
const repositoryUrl = await gitRepo(true);
await gitRepo(true);
await gitCommits(['First']);
await gitPush();
t.true(await isBranchUpToDate(repositoryUrl, 'master'));
t.true(await isBranchUpToDate('master'));
});
test.serial('Return falsy if repository is not up to date', async t => {
@@ -220,21 +220,21 @@ test.serial('Return falsy if repository is not up to date', async t => {
await gitCommits(['Second']);
await gitPush();
t.true(await isBranchUpToDate(repositoryUrl, 'master'));
t.true(await isBranchUpToDate('master'));
await gitShallowClone(repositoryUrl);
await gitCommits(['Third']);
await gitPush();
process.chdir(repoDir);
t.falsy(await isBranchUpToDate(repositoryUrl, 'master'));
t.falsy(await isBranchUpToDate('master'));
});
test.serial('Return "true" if local repository is ahead', async t => {
const repositoryUrl = await gitRepo(true);
await gitRepo(true);
await gitCommits(['First']);
await gitPush();
await gitCommits(['Second']);
t.true(await isBranchUpToDate(repositoryUrl, 'master'));
t.true(await isBranchUpToDate('master'));
});