fix: use git ls-remote
to verify if the remote branch is ahead
This commit is contained in:
parent
24a8052038
commit
2b6378f26f
15
index.js
15
index.js
@ -56,17 +56,16 @@ async function run(options, plugins) {
|
|||||||
|
|
||||||
options.repositoryUrl = await getGitAuthUrl(options);
|
options.repositoryUrl = await getGitAuthUrl(options);
|
||||||
|
|
||||||
if (!(await isBranchUpToDate(options.branch))) {
|
|
||||||
logger.log(
|
|
||||||
"The local branch %s is behind the remote one, therefore a new version won't be published.",
|
|
||||||
options.branch
|
|
||||||
);
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
|
|
||||||
try {
|
try {
|
||||||
await verifyAuth(options.repositoryUrl, options.branch);
|
await verifyAuth(options.repositoryUrl, options.branch);
|
||||||
} catch (err) {
|
} catch (err) {
|
||||||
|
if (!(await isBranchUpToDate(options.repositoryUrl, options.branch))) {
|
||||||
|
logger.log(
|
||||||
|
"The local branch %s is behind the remote one, therefore a new version won't be published.",
|
||||||
|
options.branch
|
||||||
|
);
|
||||||
|
return false;
|
||||||
|
}
|
||||||
logger.error(`The command "${err.cmd}" failed with the error message %s.`, err.stderr);
|
logger.error(`The command "${err.cmd}" failed with the error message %s.`, err.stderr);
|
||||||
throw getError('EGITNOPERMISSION', {options});
|
throw getError('EGITNOPERMISSION', {options});
|
||||||
}
|
}
|
||||||
|
11
lib/git.js
11
lib/git.js
@ -141,12 +141,19 @@ async function verifyTagName(tagName) {
|
|||||||
/**
|
/**
|
||||||
* Verify the local branch is up to date with the remote one.
|
* Verify the local branch is up to date with the remote one.
|
||||||
*
|
*
|
||||||
|
* @param {String} repositoryUrl The remote repository URL.
|
||||||
* @param {String} branch The repository branch for which to verify status.
|
* @param {String} branch The repository branch for which to verify status.
|
||||||
*
|
*
|
||||||
* @return {Boolean} `true` is the HEAD of the current local branch is the same as the HEAD of the remote branch, falsy otherwise.
|
* @return {Boolean} `true` is the HEAD of the current local branch is the same as the HEAD of the remote branch, falsy otherwise.
|
||||||
*/
|
*/
|
||||||
async function isBranchUpToDate(branch) {
|
async function isBranchUpToDate(repositoryUrl, branch) {
|
||||||
return isRefInHistory(await execa.stdout('git', ['rev-parse', `origin/${branch}`]));
|
try {
|
||||||
|
return await isRefInHistory(
|
||||||
|
(await execa.stdout('git', ['ls-remote', '--heads', repositoryUrl, branch])).match(/^(\w+)?/)[1]
|
||||||
|
);
|
||||||
|
} catch (err) {
|
||||||
|
debug(err);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
module.exports = {
|
module.exports = {
|
||||||
|
@ -24,7 +24,6 @@ import {
|
|||||||
gitCommitTag,
|
gitCommitTag,
|
||||||
gitRemoteTagHead,
|
gitRemoteTagHead,
|
||||||
push as pushUtil,
|
push as pushUtil,
|
||||||
reset,
|
|
||||||
} from './helpers/git-utils';
|
} from './helpers/git-utils';
|
||||||
|
|
||||||
// Save the current working diretory
|
// Save the current working diretory
|
||||||
@ -189,31 +188,35 @@ test.serial('Throws error if obtaining the tags fails', async t => {
|
|||||||
});
|
});
|
||||||
|
|
||||||
test.serial('Return "true" if repository is up to date', async t => {
|
test.serial('Return "true" if repository is up to date', async t => {
|
||||||
await gitRepo(true);
|
const repositoryUrl = await gitRepo(true);
|
||||||
await gitCommits(['First']);
|
await gitCommits(['First']);
|
||||||
await pushUtil();
|
await pushUtil();
|
||||||
|
|
||||||
t.true(await isBranchUpToDate('master'));
|
t.true(await isBranchUpToDate(repositoryUrl, 'master'));
|
||||||
});
|
});
|
||||||
|
|
||||||
test.serial('Return falsy if repository is not up to date', async t => {
|
test.serial('Return falsy if repository is not up to date', async t => {
|
||||||
await gitRepo(true);
|
const repositoryUrl = await gitRepo(true);
|
||||||
|
const repoDir = process.cwd();
|
||||||
await gitCommits(['First']);
|
await gitCommits(['First']);
|
||||||
await gitCommits(['Second']);
|
await gitCommits(['Second']);
|
||||||
await pushUtil();
|
await pushUtil();
|
||||||
|
|
||||||
t.true(await isBranchUpToDate('master'));
|
t.true(await isBranchUpToDate(repositoryUrl, 'master'));
|
||||||
|
|
||||||
await reset();
|
await gitShallowClone(repositoryUrl);
|
||||||
|
await gitCommits(['Third']);
|
||||||
|
await pushUtil();
|
||||||
|
process.chdir(repoDir);
|
||||||
|
|
||||||
t.falsy(await isBranchUpToDate('master'));
|
t.falsy(await isBranchUpToDate(repositoryUrl, 'master'));
|
||||||
});
|
});
|
||||||
|
|
||||||
test.serial('Return "true" if local repository is ahead', async t => {
|
test.serial('Return "true" if local repository is ahead', async t => {
|
||||||
await gitRepo(true);
|
const repositoryUrl = await gitRepo(true);
|
||||||
await gitCommits(['First']);
|
await gitCommits(['First']);
|
||||||
await pushUtil();
|
await pushUtil();
|
||||||
await gitCommits(['Second']);
|
await gitCommits(['Second']);
|
||||||
|
|
||||||
t.true(await isBranchUpToDate('master'));
|
t.true(await isBranchUpToDate(repositoryUrl, 'master'));
|
||||||
});
|
});
|
||||||
|
@ -212,12 +212,3 @@ export async function gitCommitTag(gitHead) {
|
|||||||
export async function push(repositoryUrl = 'origin', branch = 'master') {
|
export async function push(repositoryUrl = 'origin', branch = 'master') {
|
||||||
await execa('git', ['push', '--tags', repositoryUrl, `HEAD:${branch}`]);
|
await execa('git', ['push', '--tags', repositoryUrl, `HEAD:${branch}`]);
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
|
||||||
* Reset repository to a commit.
|
|
||||||
*
|
|
||||||
* @param {String} [commit='HEAD~1'] Commit reference to reset the repo to.
|
|
||||||
*/
|
|
||||||
export async function reset(commit = 'HEAD~1') {
|
|
||||||
await execa('git', ['reset', commit]);
|
|
||||||
}
|
|
||||||
|
@ -15,7 +15,6 @@ import {
|
|||||||
gitRemoteTagHead,
|
gitRemoteTagHead,
|
||||||
push,
|
push,
|
||||||
gitShallowClone,
|
gitShallowClone,
|
||||||
reset,
|
|
||||||
} from './helpers/git-utils';
|
} from './helpers/git-utils';
|
||||||
|
|
||||||
// Save the current process.env
|
// Save the current process.env
|
||||||
@ -645,11 +644,15 @@ test.serial('Returns falsy value if triggered by a PR', async t => {
|
|||||||
test.serial('Returns falsy value if triggered on an outdated clone', async t => {
|
test.serial('Returns falsy value if triggered on an outdated clone', async t => {
|
||||||
// Create a git repository, set the current working directory at the root of the repo
|
// Create a git repository, set the current working directory at the root of the repo
|
||||||
const repositoryUrl = await gitRepo(true);
|
const repositoryUrl = await gitRepo(true);
|
||||||
|
const repoDir = process.cwd();
|
||||||
// Add commits to the master branch
|
// Add commits to the master branch
|
||||||
await gitCommits(['First']);
|
await gitCommits(['First']);
|
||||||
await gitCommits(['Second']);
|
await gitCommits(['Second']);
|
||||||
await push();
|
await push();
|
||||||
await reset();
|
await gitShallowClone(repositoryUrl);
|
||||||
|
await gitCommits(['Third']);
|
||||||
|
await push();
|
||||||
|
process.chdir(repoDir);
|
||||||
|
|
||||||
const semanticRelease = proxyquire('..', {
|
const semanticRelease = proxyquire('..', {
|
||||||
'./lib/logger': t.context.logger,
|
'./lib/logger': t.context.logger,
|
||||||
|
@ -2,7 +2,7 @@ import test from 'ava';
|
|||||||
import {writeJson, readJson} from 'fs-extra';
|
import {writeJson, readJson} from 'fs-extra';
|
||||||
import {stub} from 'sinon';
|
import {stub} from 'sinon';
|
||||||
import execa from 'execa';
|
import execa from 'execa';
|
||||||
import {gitHead as getGitHead, gitTagHead, gitRepo, gitCommits, gitRemoteTagHead} from './helpers/git-utils';
|
import {gitHead as getGitHead, gitTagHead, gitRepo, gitCommits, gitRemoteTagHead, push} from './helpers/git-utils';
|
||||||
import gitbox from './helpers/gitbox';
|
import gitbox from './helpers/gitbox';
|
||||||
import mockServer from './helpers/mockserver';
|
import mockServer from './helpers/mockserver';
|
||||||
import npmRegistry from './helpers/npm-registry';
|
import npmRegistry from './helpers/npm-registry';
|
||||||
@ -609,6 +609,7 @@ test.serial('Exit with 1 if missing permission to push to the remote repository'
|
|||||||
/* Initial release */
|
/* Initial release */
|
||||||
t.log('Commit a feature');
|
t.log('Commit a feature');
|
||||||
await gitCommits(['feat: Initial commit']);
|
await gitCommits(['feat: Initial commit']);
|
||||||
|
await push();
|
||||||
t.log('$ semantic-release');
|
t.log('$ semantic-release');
|
||||||
const {stdout, code} = await execa(
|
const {stdout, code} = await execa(
|
||||||
cli,
|
cli,
|
||||||
|
Loading…
x
Reference in New Issue
Block a user