fix: prevent git prompt before permissions verification

lib/get-config.js

@@ -6,7 +6,6 @@ const debug = require('debug')('semantic-release:config');
 const {repoUrl} = require('./git');
 const PLUGINS_DEFINITIONS = require('./definitions/plugins');
 const plugins = require('./plugins');
-const getGitAuthUrl = require('./get-git-auth-url');
 
 module.exports = async (opts, logger) => {
   const {config} = (await cosmiconfig('release', {rcExtensions: true}).load(process.cwd())) || {};
@@ -51,8 +50,6 @@ module.exports = async (opts, logger) => {
     ...pickBy(options, option => !isUndefined(option) && !isNull(option)),
   };
 
-  options.repositoryUrl = await getGitAuthUrl(options);
-
   debug('options values: %O', options);
 
   return {options, plugins: await plugins(options, pluginsPath, logger)};

lib/get-git-auth-url.js

@@ -17,38 +17,36 @@ const GIT_TOKENS = ['GIT_CREDENTIALS', 'GH_TOKEN', 'GITHUB_TOKEN', 'GL_TOKEN', '
  * @return {String} The formatted Git repository URL.
  */
 module.exports = async ({repositoryUrl, branch}) => {
-  if (repositoryUrl) {
-    const info = hostedGitInfo.fromUrl(repositoryUrl, {noGitPlus: true});
+  const info = hostedGitInfo.fromUrl(repositoryUrl, {noGitPlus: true});
 
-    if (info && info.getDefaultRepresentation() === 'shortcut') {
-      // Expand shorthand URLs (such as `owner/repo` or `gitlab:owner/repo`)
-      repositoryUrl = info.https();
-    } else {
-      const {protocols} = gitUrlParse(repositoryUrl);
+  if (info && info.getDefaultRepresentation() === 'shortcut') {
+    // Expand shorthand URLs (such as `owner/repo` or `gitlab:owner/repo`)
+    repositoryUrl = info.https();
+  } else {
+    const {protocols} = gitUrlParse(repositoryUrl);
 
-      // Replace `git+https` and `git+http` with `https` or `http`
-      if (protocols.includes('http') || protocols.includes('https')) {
-        repositoryUrl = format({
-          ...parse(repositoryUrl),
-          ...{protocol: protocols.includes('https') ? 'https' : 'http'},
-        });
-      }
+    // Replace `git+https` and `git+http` with `https` or `http`
+    if (protocols.includes('http') || protocols.includes('https')) {
+      repositoryUrl = format({
+        ...parse(repositoryUrl),
+        ...{protocol: protocols.includes('https') ? 'https' : 'http'},
+      });
     }
+  }
 
-    // Test if push is allowed without transforming the URL (e.g. is ssh keys are set up)
-    if (!await verifyAuth(repositoryUrl, branch)) {
-      const envVar = GIT_TOKENS.find(envVar => !isUndefined(process.env[envVar]));
-      const gitCredentials = ['GL_TOKEN', 'GITLAB_TOKEN'].includes(envVar)
-        ? `gitlab-ci-token:${process.env[envVar]}`
-        : process.env[envVar];
-      const {protocols} = gitUrlParse(repositoryUrl);
-      const protocol = protocols.includes('https') ? 'https' : protocols.includes('http') ? 'http' : 'https';
+  // Test if push is allowed without transforming the URL (e.g. is ssh keys are set up)
+  if (!await verifyAuth(repositoryUrl, branch)) {
+    const envVar = GIT_TOKENS.find(envVar => !isUndefined(process.env[envVar]));
+    const gitCredentials = ['GL_TOKEN', 'GITLAB_TOKEN'].includes(envVar)
+      ? `gitlab-ci-token:${process.env[envVar]}`
+      : process.env[envVar];
+    const {protocols} = gitUrlParse(repositoryUrl);
+    const protocol = protocols.includes('https') ? 'https' : protocols.includes('http') ? 'http' : 'https';
 
-      // If credentials are set via anvironment variables, convert the URL to http/https and add basic auth, otherwise return `repositoryUrl` as is
-      return gitCredentials
-        ? format({...parse(`${gitUrlParse(repositoryUrl).toString(protocol)}.git`), ...{auth: gitCredentials}})
-        : repositoryUrl;
-    }
+    // If credentials are set via anvironment variables, convert the URL to http/https and add basic auth, otherwise return `repositoryUrl` as is
+    return gitCredentials
+      ? format({...parse(`${gitUrlParse(repositoryUrl).toString(protocol)}.git`), ...{auth: gitCredentials}})
+      : repositoryUrl;
   }
   return repositoryUrl;
 };

lib/verify.js

@@ -1,6 +1,6 @@
 const {template} = require('lodash');
 const AggregateError = require('aggregate-error');
-const {isGitRepo, verifyAuth, verifyTagName} = require('./git');
+const {isGitRepo, verifyTagName} = require('./git');
 const getError = require('./get-error');
 
 module.exports = async options => {
@@ -10,8 +10,6 @@ module.exports = async options => {
     errors.push(getError('ENOGITREPO'));
   } else if (!options.repositoryUrl) {
     errors.push(getError('ENOREPOURL'));
-  } else if (!await verifyAuth(options.repositoryUrl, options.branch)) {
-    errors.push(getError('EGITNOPERMISSION', {options}));
   }
 
   // Verify that compiling the `tagFormat` produce a valid Git tag