From 4053d8f7fbca0bd985f76b6638f19b48c295d623 Mon Sep 17 00:00:00 2001 From: Pierre Vanduynslager Date: Sun, 10 Dec 2017 03:56:30 -0500 Subject: [PATCH] fix: log plugin type in addition of path --- lib/plugins/normalize.js | 2 +- test/plugins/normalize.test.js | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/plugins/normalize.js b/lib/plugins/normalize.js index 4b508a9e..8cae2fd6 100644 --- a/lib/plugins/normalize.js +++ b/lib/plugins/normalize.js @@ -8,7 +8,7 @@ module.exports = (pluginType, pluginConfig, logger, validator) => { } const {path, ...config} = isString(pluginConfig) || isFunction(pluginConfig) ? {path: pluginConfig} : pluginConfig; if (!isFunction(pluginConfig)) { - logger.log('Load plugin %s', path); + logger.log('Load plugin %s from %s', pluginType, path); } const plugin = isFunction(path) ? path : importFrom.silent(__dirname, path) || importFrom(process.cwd(), path); diff --git a/test/plugins/normalize.test.js b/test/plugins/normalize.test.js index 51711177..508c7035 100644 --- a/test/plugins/normalize.test.js +++ b/test/plugins/normalize.test.js @@ -10,17 +10,17 @@ test.beforeEach(t => { }); test('Normalize and load plugin from string', t => { - const plugin = normalize('', './test/fixtures/plugin-noop', t.context.logger); + const plugin = normalize('verifyConditions', './test/fixtures/plugin-noop', t.context.logger); t.is(typeof plugin, 'function'); - t.true(t.context.log.calledWith(match.string, './test/fixtures/plugin-noop')); + t.true(t.context.log.calledWith(match.string, 'verifyConditions', './test/fixtures/plugin-noop')); }); test('Normalize and load plugin from object', t => { - const plugin = normalize('', {path: './test/fixtures/plugin-noop'}, t.context.logger); + const plugin = normalize('publish', {path: './test/fixtures/plugin-noop'}, t.context.logger); t.is(typeof plugin, 'function'); - t.true(t.context.log.calledWith(match.string, './test/fixtures/plugin-noop')); + t.true(t.context.log.calledWith(match.string, 'publish', './test/fixtures/plugin-noop')); }); test('Normalize and load plugin from function', t => { @@ -33,7 +33,7 @@ test('Normalize and load plugin that retuns multiple functions', t => { const plugin = normalize('verifyConditions', './test/fixtures/multi-plugin', t.context.logger); t.is(typeof plugin, 'function'); - t.true(t.context.log.calledWith(match.string, './test/fixtures/multi-plugin')); + t.true(t.context.log.calledWith(match.string, 'verifyConditions', './test/fixtures/multi-plugin')); }); test('Wrap plugin in a function that validate the output of the plugin', async t => {