simon/semantic-release
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(verify): ensure repo url in package.json is well formed

Browse Source
This commit is contained in:
Stephan Bönnemann 2015-07-16 14:07:52 +02:00
parent dbea5cc1b1
commit 431babb42e
2 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/lib/verify.js
View File

@ -1,3 +1,5 @@
const parseSlug = require('parse-github-repo-url')
const SemanticReleaseError = require('@semantic-release/error')
module.exports = function (pkg, options, env) {
@ -15,6 +17,11 @@ module.exports = function (pkg, options, env) {
'No "repository" found in package.json.',
'ENOPKGREPO'
))
} else if (!parseSlug(pkg.repository.url)) {
errors.push(new SemanticReleaseError(
'The "repository" field in the package.json is malformed.',
'EMALFORMEDPKGREPO'
))
}
if (options.debug) return errors

12
test/specs/verify.js
View File

@ -23,6 +23,18 @@ test('verify pkg, options and env', (t) => {
tt.is(errors[0].code, 'ENOPKGNAME')
tt.is(errors[1].code, 'ENOPKGREPO')
const errors2 = verify({
name: 'package',
repository: {
url: 'lol'
}
}, {
debug: true
}, {})
tt.is(errors2.length, 1)
tt.is(errors2[0].code, 'EMALFORMEDPKGREPO')
tt.end()
})