simon/semantic-release
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: set default path to generateNotes object config

Browse Source
This commit is contained in:
Pierre Vanduynslager 2018-07-10 15:42:39 -04:00
parent 24ce560065
commit d8e59cce53
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/plugins/index.js
View File

@ -17,9 +17,10 @@ module.exports = (options, pluginsPath, logger) => {
if (isUndefined(options[type])) { if (isUndefined(options[type])) {
pluginConfs = def; pluginConfs = def;
} else { } else {
const defaultPaths = castArray(def);
// If an object is passed and the path is missing, set the default one for single plugins // If an object is passed and the path is missing, set the default one for single plugins
if (isPlainObject(options[type]) && !options[type].path && castArray(def).length === 1) { if (isPlainObject(options[type]) && !options[type].path && defaultPaths.length === 1) {
options[type].path = def; [options[type].path] = defaultPaths;
} }
if (configValidator && !configValidator(options[type])) { if (configValidator && !configValidator(options[type])) {
errors.push(getError('EPLUGINCONF', {type, pluginConf: options[type]})); errors.push(getError('EPLUGINCONF', {type, pluginConf: options[type]}));

4
test/plugins/plugins.test.js
View File

@ -117,13 +117,15 @@ test.serial('Export plugins loaded from the dependency of a shareable config fil
test('Use default when only options are passed for a single plugin', t => { test('Use default when only options are passed for a single plugin', t => {
const analyzeCommits = {}; const analyzeCommits = {};
const generateNotes = {};
const success = () => {}; const success = () => {};
const fail = [() => {}]; const fail = [() => {}];
const plugins = getPlugins({analyzeCommits, success, fail}, {}, t.context.logger); const plugins = getPlugins({analyzeCommits, generateNotes, success, fail}, {}, t.context.logger);
// Verify the module returns a function for each plugin // Verify the module returns a function for each plugin
t.is(typeof plugins.analyzeCommits, 'function'); t.is(typeof plugins.analyzeCommits, 'function');
t.is(typeof plugins.generateNotes, 'function');
t.is(typeof plugins.success, 'function'); t.is(typeof plugins.success, 'function');
t.is(typeof plugins.fail, 'function'); t.is(typeof plugins.fail, 'function');