simon/semantic-release
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: escape uri encoded symbols (#1697)

Browse Source
This commit is contained in:
Dmitriy Dekhanov 2020-11-19 22:55:09 +03:00 committed by GitHub
parent c8d38b6258
commit f8f8fbcac4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/hide-sensitive.js
View File

@ -12,7 +12,7 @@ module.exports = (env) => {
}); });
const regexp = new RegExp( const regexp = new RegExp(
toReplace.map((envVar) => `${escapeRegExp(env[envVar])}|${encodeURI(escapeRegExp(env[envVar]))}`).join('|'), toReplace.map((envVar) => `${escapeRegExp(env[envVar])}|${escapeRegExp(encodeURI(env[envVar]))}`).join('|'),
'g' 'g'
); );
return (output) => return (output) =>

8
test/hide-sensitive.test.js
View File

@ -40,6 +40,14 @@ test('Escape regexp special characters', (t) => {
); );
}); });
test('Escape regexp special characters in url-encoded environment variable', (t) => {
const env = {SOME_PASSWORD: 'secret password p$^{.+}\\w[a-z]o.*rd)('};
t.is(
hideSensitive(env)(`https://user:${encodeURI(env.SOME_PASSWORD)}@host.com`),
`https://user:${SECRET_REPLACEMENT}@host.com`
);
});
test('Accept "undefined" input', (t) => { test('Accept "undefined" input', (t) => {
t.is(hideSensitive({})(), undefined); t.is(hideSensitive({})(), undefined);
}); });