simon/semantic-release
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: remove unnecessary branch parameter from push function

Browse Source
This commit is contained in:
Pierre Vanduynslager 2018-11-29 20:00:01 -05:00
parent 7a9922a492
commit ffe1062830
3 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
index.js
View File

@ -107,7 +107,7 @@ async function run(context, plugins) {
} else { } else {
// Create the tag before calling the publish plugins as some require the tag to exists // Create the tag before calling the publish plugins as some require the tag to exists
await tag(nextRelease.gitTag, {cwd, env}); await tag(nextRelease.gitTag, {cwd, env});
await push(options.repositoryUrl, options.branch, {cwd, env}); await push(options.repositoryUrl, {cwd, env});
logger.success(`Created tag ${nextRelease.gitTag}`); logger.success(`Created tag ${nextRelease.gitTag}`);
} }

3
lib/git.js
View File

@ -143,12 +143,11 @@ async function tag(tagName, execaOpts) {
* Push to the remote repository. * Push to the remote repository.
* *
* @param {String} repositoryUrl The remote repository URL. * @param {String} repositoryUrl The remote repository URL.
* @param {String} branch The branch to push.
* @param {Object} [execaOpts] Options to pass to `execa`. * @param {Object} [execaOpts] Options to pass to `execa`.
* *
* @throws {Error} if the push failed. * @throws {Error} if the push failed.
*/ */
async function push(repositoryUrl, branch, execaOpts) { async function push(repositoryUrl, execaOpts) {
await execa('git', ['push', '--tags', repositoryUrl], execaOpts); await execa('git', ['push', '--tags', repositoryUrl], execaOpts);
} }

4
test/git.test.js
View File

@ -157,7 +157,7 @@ test('Push tag to remote repository', async t => {
const commits = await gitCommits(['Test commit'], {cwd}); const commits = await gitCommits(['Test commit'], {cwd});
await tag('tag_name', {cwd}); await tag('tag_name', {cwd});
await push(repositoryUrl, 'master', {cwd}); await push(repositoryUrl, {cwd});
t.is(await gitRemoteTagHead(repositoryUrl, 'tag_name', {cwd}), commits[0].hash); t.is(await gitRemoteTagHead(repositoryUrl, 'tag_name', {cwd}), commits[0].hash);
}); });
@ -171,7 +171,7 @@ test('Push tag to remote repository with remote branch ahaed', async t => {
await gitPush('origin', 'master', {cwd: tmpRepo}); await gitPush('origin', 'master', {cwd: tmpRepo});
await tag('tag_name', {cwd}); await tag('tag_name', {cwd});
await push(repositoryUrl, 'master', {cwd}); await push(repositoryUrl, {cwd});
t.is(await gitRemoteTagHead(repositoryUrl, 'tag_name', {cwd}), commits[0].hash); t.is(await gitRemoteTagHead(repositoryUrl, 'tag_name', {cwd}), commits[0].hash);
}); });