fix: convert git+https URL in package.json to https

docs/usage/configuration.md

@@ -105,7 +105,7 @@ Default: `false`
 
 CLI argument: `--debug`
 
-Output debugging information. It can also be enabled by set the `DEBUG` environment variable to `semantic-release`.
+Output debugging information. It can also be enabled by set the `DEBUG` environment variable to `semantic-release:*`.
 
 ### verifyConditions
 

lib/get-config.js

@@ -2,6 +2,7 @@ const {castArray, pickBy, isUndefined, isNull, isString, isPlainObject} = requir
 const readPkgUp = require('read-pkg-up');
 const cosmiconfig = require('cosmiconfig');
 const resolveFrom = require('resolve-from');
+const gitUrlParse = require('git-url-parse');
 const debug = require('debug')('semantic-release:config');
 const {repoUrl, verifyAuth} = require('./git');
 const PLUGINS_DEFINITIONS = require('./definitions/plugins');
@@ -61,6 +62,13 @@ module.exports = async (opts, logger) => {
 };
 
 async function pkgRepoUrl() {
-  const {pkg} = await readPkgUp();
-  return pkg && pkg.repository ? pkg.repository.url : undefined;
+  const {pkg} = await readPkgUp({normalize: false});
+  const repositoryUrl = pkg && (isPlainObject(pkg.repository) ? pkg.repository.url : pkg.repository);
+
+  if (repositoryUrl) {
+    const {protocols} = gitUrlParse(repositoryUrl);
+    return `${gitUrlParse(repositoryUrl).toString(
+      protocols.includes('https') ? 'https' : protocols.includes('http') ? 'http' : undefined
+    )}${protocols.includes('https') || protocols.includes('http') ? '.git' : ''}`;
+  }
 }

lib/get-last-release.js

@@ -33,7 +33,9 @@ module.exports = async (tagFormat, logger) => {
     .map(tag => {
       return {gitTag: tag, version: (tag.match(tagRegexp) || new Array(2))[1]};
     })
-    .filter(tag => tag.version && semver.valid(semver.clean(tag.version)))
+    .filter(
+      tag => tag.version && semver.valid(semver.clean(tag.version)) && !semver.prerelease(semver.clean(tag.version))
+    )
     .sort((a, b) => semver.rcompare(a.version, b.version));
 
   debug('found tags: %o', tags);

lib/git.js

@@ -1,5 +1,5 @@
 const execa = require('execa');
-const debug = require('debug')('semantic-release:get-version-head');
+const debug = require('debug')('semantic-release:git');
 
 /**
  * Get the commit sha for a given tag.

test/get-last-release.test.js

@@ -17,7 +17,7 @@ test.afterEach.always(() => {
   process.chdir(cwd);
 });
 
-test.serial('Get the highest valid tag', async t => {
+test.serial('Get the highest non-prerelease valid tag', async t => {
   // Create a git repository, set the current working directory at the root of the repo
   await gitRepo();
   // Create some commits and tags
@@ -29,6 +29,8 @@ test.serial('Get the highest valid tag', async t => {
   await gitTagVersion('v1.0.0');
   await gitCommits(['Fourth']);
   await gitTagVersion('v3.0');
+  await gitCommits(['Fifth']);
+  await gitTagVersion('v3.0.0-beta.1');
 
   const result = await getLastRelease(`v\${version}`, t.context.logger);
 
@@ -117,4 +119,11 @@ test.serial('Get the highest valid tag corresponding to the "tagFormat"', async
     gitTag: '2.0.0-1.0.0-bar.1',
     version: '1.0.0',
   });
+
+  await gitTagVersion('3.0.0-bar.1');
+  t.deepEqual(await getLastRelease(`\${version}-bar.1`, t.context.logger), {
+    gitHead,
+    gitTag: '3.0.0-bar.1',
+    version: '3.0.0',
+  });
 });

test/integration.test.js

@@ -604,17 +604,17 @@ test.serial('Exit with 1 if missing permission to push to the remote repository'
   // Create a git repository, set the current working directory at the root of the repo
   t.log('Create git repository');
   await gitbox.createRepo(packageName);
-  await writeJson('./package.json', {
-    name: packageName,
-    version: '0.0.0-dev',
-    repository: {url: 'http://user:wrong_pass@localhost:2080/git/unauthorized.git'},
-  });
+  await writeJson('./package.json', {name: packageName, version: '0.0.0-dev'});
 
   /* Initial release */
   t.log('Commit a feature');
   await gitCommits(['feat: Initial commit']);
   t.log('$ semantic-release');
-  const {stdout, code} = await execa(cli, [], {env: {...env, ...{GH_TOKEN: 'user:wrong_pass'}}, reject: false});
+  const {stdout, code} = await execa(
+    cli,
+    ['--repository-url', 'http://user:wrong_pass@localhost:2080/git/unauthorized.git'],
+    {env: {...env, ...{GH_TOKEN: 'user:wrong_pass'}}, reject: false}
+  );
   // Verify the type and message are logged
   t.regex(stdout, /EGITNOPERMISSION/);
   t.is(code, 1);