fix: correctly resolve plugins installed globally with npx

This bug affects only plugins defined with the `plugins` option and wrapped in an Array to add a configuration

docs/support/resources.md

@@ -4,17 +4,17 @@
 
 - ["Introducing Reliable Dependency and Release Management for npm Packages" - Gregor Martynus](https://www.youtube.com/watch?v=R2RJWLcfzwc)
 - ["Kill all humans" - Jan Lehnardt](https://www.youtube.com/watch?v=ZXyx_1kN1L8&t=2s)
-- [Publishing JavaScript Packages" - JavaScript Air](https://javascriptair.com/episodes/2016-07-20)
+- ["Publishing JavaScript Packages" - JavaScript Air](https://javascriptair.com/episodes/2016-07-20)
 - ["Managing Dependencies like a boss 😎" - JavaScript Air](https://javascriptair.com/episodes/2016-08-17)
 - ["Dependency Hell Just Froze Over" - Stephan Bönnemann](https://www.youtube.com/watch?v=PA139CERNbc)
-- [“semantic-release Q&A with Kent C. Dodds”](https://www.youtube.com/watch?v=g6y3DnhkjrI)
-- [“We fail to follow SemVer – and why it needn’t matter” - Stephan Bönnemann](https://www.youtube.com/watch?v=tc2UgG5L7WM)
+- ["semantic-release Q&A with Kent C. Dodds"](https://www.youtube.com/watch?v=g6y3DnhkjrI)
+- ["We fail to follow SemVer – and why it needn’t matter" - Stephan Bönnemann](https://www.youtube.com/watch?v=tc2UgG5L7WM)
 
 ## Articles
 
-- [“Introduction to SemVer” - Irina Gebauer](https://blog.greenkeeper.io/introduction-to-semver-d272990c44f2)
+- ["Introduction to SemVer" - Irina Gebauer](https://blog.greenkeeper.io/introduction-to-semver-d272990c44f2)
 - ["Introduction to Semantic Release" - liv](https://blog.greenkeeper.io/introduction-to-semantic-release-33f73b117c8)
 
 ## Tutorials
 
-- [“How to Write a JavaScript Library - Automating Releases with semantic-release” – egghead.io](https://egghead.io/lessons/javascript-automating-releases-with-semantic-release)
+- ["How to Write a JavaScript Library - Automating Releases with semantic-release" – egghead.io](https://egghead.io/lessons/javascript-automating-releases-with-semantic-release)

docs/usage/ci-configuration.md

@@ -2,7 +2,7 @@
 
 ## Run `semantic-release` only after all tests succeeded
 
-The `semantic-release` command must be executed only after all the tests in the CI build pass. If the build runs multiple jobs (for example to test on multiple Operating Systems or Node versions) the CI has to be configured to guarantee that the `semantic-release` command is executed only after all jobs are successful. This can be achieved with [Travis Build Stages](https://docs.travis-ci.com/user/build-stages), [CircleCI Workflows](https://circleci.com/docs/2.0/workflows), [Codeship Deployment Pipelines](https://documentation.codeship.com/basic/builds-and-configuration/deployment-pipelines), [GitLab Pipelines](https://docs.gitlab.com/ee/ci/pipelines.html#introduction-to-pipelines-and-jobs), [Wercker Workflows](http://devcenter.wercker.com/docs/workflows), [GoCD Pipelines](https://docs.gocd.org/current/introduction/concepts_in_go.html#pipeline) or specific tools like [`travis-deploy-once`](https://github.com/semantic-release/travis-deploy-once).
+The `semantic-release` command must be executed only after all the tests in the CI build pass. If the build runs multiple jobs (for example to test on multiple Operating Systems or Node versions) the CI has to be configured to guarantee that the `semantic-release` command is executed only after all jobs are successful. This can be achieved with [Travis Build Stages](https://docs.travis-ci.com/user/build-stages), [CircleCI Workflows](https://circleci.com/docs/2.0/workflows), [Codeship Deployment Pipelines](https://documentation.codeship.com/basic/builds-and-configuration/deployment-pipelines), [GitLab Pipelines](https://docs.gitlab.com/ee/ci/pipelines.html#introduction-to-pipelines-and-jobs), [Codefresh Pipelines](https://codefresh.io/docs/docs/configure-ci-cd-pipeline/introduction-to-codefresh-pipelines), [Wercker Workflows](http://devcenter.wercker.com/docs/workflows), [GoCD Pipelines](https://docs.gocd.org/current/introduction/concepts_in_go.html#pipeline) or specific tools like [`travis-deploy-once`](https://github.com/semantic-release/travis-deploy-once).
 
 See [CI configuration recipes](../recipes/README.md#ci-configurations) for more details.
 

index.js

@@ -13,7 +13,7 @@ const getLastRelease = require('./lib/get-last-release');
 const {extractErrors} = require('./lib/utils');
 const getGitAuthUrl = require('./lib/get-git-auth-url');
 const getLogger = require('./lib/get-logger');
-const {fetch, verifyAuth, isBranchUpToDate, gitHead: getGitHead, tag, push} = require('./lib/git');
+const {fetch, verifyAuth, isBranchUpToDate, getGitHead, tag, push} = require('./lib/git');
 const getError = require('./lib/get-error');
 const {COMMIT_NAME, COMMIT_EMAIL} = require('./lib/definitions/constants');
 

lib/definitions/plugins.js

@@ -1,5 +1,5 @@
 const {isString, isPlainObject} = require('lodash');
-const {gitHead} = require('../git');
+const {getGitHead} = require('../git');
 const hideSensitive = require('../hide-sensitive');
 const {hideSensitiveValues} = require('../utils');
 const {RELEASE_TYPE, RELEASE_NOTES_SEPARATOR} = require('./constants');
@@ -52,7 +52,7 @@ module.exports = {
     dryRun: false,
     pipelineConfig: ({generateNotes}) => ({
       getNextInput: async context => {
-        const newGitHead = await gitHead({cwd: context.cwd});
+        const newGitHead = await getGitHead({cwd: context.cwd});
         // If previous prepare plugin has created a commit (gitHead changed)
         if (context.nextRelease.gitHead !== newGitHead) {
           context.nextRelease.gitHead = newGitHead;

lib/get-config.js

@@ -6,6 +6,7 @@ const debug = require('debug')('semantic-release:config');
 const {repoUrl} = require('./git');
 const PLUGINS_DEFINITIONS = require('./definitions/plugins');
 const plugins = require('./plugins');
+const {validatePlugin, parseConfig} = require('./plugins/utils');
 
 const CONFIG_NAME = 'release';
 const CONFIG_FILES = [
@@ -37,17 +38,21 @@ module.exports = async (context, opts) => {
 
         // For each plugin defined in a shareable config, save in `pluginsPath` the extendable config path,
         // so those plugin will be loaded relatively to the config file
-        Object.entries(extendsOpts).reduce((pluginsPath, [option, value]) => {
-          if (PLUGINS_DEFINITIONS[option] || option === 'plugins') {
-            castArray(value)
-              .filter(plugin => isString(plugin) || (isPlainObject(plugin) && isString(plugin.path)))
-              .map(plugin => (isString(plugin) ? plugin : plugin.path))
-              .forEach(plugin => {
-                pluginsPath[plugin] = extendPath;
-              });
-          }
-          return pluginsPath;
-        }, pluginsPath);
+        Object.entries(extendsOpts)
+          .filter(([, value]) => Boolean(value))
+          .reduce((pluginsPath, [option, value]) => {
+            castArray(value).forEach(plugin => {
+              if (option === 'plugins' && validatePlugin(plugin)) {
+                pluginsPath[parseConfig(plugin)[0]] = extendPath;
+              } else if (
+                PLUGINS_DEFINITIONS[option] &&
+                (isString(plugin) || (isPlainObject(plugin) && isString(plugin.path)))
+              ) {
+                pluginsPath[isString(plugin) ? plugin : plugin.path] = extendPath;
+              }
+            });
+            return pluginsPath;
+          }, pluginsPath);
 
         return {...result, ...extendsOpts};
       }, {}),

lib/get-last-release.js

@@ -2,7 +2,7 @@ const {escapeRegExp, template} = require('lodash');
 const semver = require('semver');
 const pLocate = require('p-locate');
 const debug = require('debug')('semantic-release:get-last-release');
-const {gitTags, isRefInHistory, gitTagHead} = require('./git');
+const {getTags, isRefInHistory, getTagHead} = require('./git');
 
 /**
  * Last release.
@@ -30,7 +30,7 @@ module.exports = async ({cwd, env, options: {tagFormat}, logger}) => {
   // The `tagFormat` is compiled with space as the `version` as it's an invalid tag character,
   // so it's guaranteed to no be present in the `tagFormat`.
   const tagRegexp = `^${escapeRegExp(template(tagFormat)({version: ' '})).replace(' ', '(.+)')}`;
-  const tags = (await gitTags({cwd, env}))
+  const tags = (await getTags({cwd, env}))
     .map(tag => ({gitTag: tag, version: (tag.match(tagRegexp) || new Array(2))[1]}))
     .filter(
       tag => tag.version && semver.valid(semver.clean(tag.version)) && !semver.prerelease(semver.clean(tag.version))
@@ -43,7 +43,7 @@ module.exports = async ({cwd, env, options: {tagFormat}, logger}) => {
 
   if (tag) {
     logger.log(`Found git tag ${tag.gitTag} associated with version ${tag.version}`);
-    return {gitHead: await gitTagHead(tag.gitTag, {cwd, env}), ...tag};
+    return {gitHead: await getTagHead(tag.gitTag, {cwd, env}), ...tag};
   }
 
   logger.log('No git tag version found');

lib/git.js

@@ -4,12 +4,12 @@ const debug = require('debug')('semantic-release:git');
 /**
  * Get the commit sha for a given tag.
  *
- * @param {string} tagName Tag name for which to retrieve the commit sha.
+ * @param {String} tagName Tag name for which to retrieve the commit sha.
  * @param {Object} [execaOpts] Options to pass to `execa`.
  *
  * @return {string} The commit sha of the tag in parameter or `null`.
  */
-async function gitTagHead(tagName, execaOpts) {
+async function getTagHead(tagName, execaOpts) {
   try {
     return await execa.stdout('git', ['rev-list', '-1', tagName], execaOpts);
   } catch (error) {
@@ -25,20 +25,20 @@ async function gitTagHead(tagName, execaOpts) {
  * @return {Array<String>} List of git tags.
  * @throws {Error} If the `git` command fails.
  */
-async function gitTags(execaOpts) {
+async function getTags(execaOpts) {
   return (await execa.stdout('git', ['tag'], execaOpts))
     .split('\n')
     .map(tag => tag.trim())
-    .filter(tag => Boolean(tag));
+    .filter(Boolean);
 }
 
 /**
  * Verify if the `ref` is in the direct history of the current branch.
  *
- * @param {string} ref The reference to look for.
+ * @param {String} ref The reference to look for.
  * @param {Object} [execaOpts] Options to pass to `execa`.
  *
- * @return {boolean} `true` if the reference is in the history of the current branch, falsy otherwise.
+ * @return {Boolean} `true` if the reference is in the history of the current branch, falsy otherwise.
  */
 async function isRefInHistory(ref, execaOpts) {
   try {
@@ -73,9 +73,9 @@ async function fetch(repositoryUrl, execaOpts) {
  *
  * @param {Object} [execaOpts] Options to pass to `execa`.
  *
- * @return {string} the sha of the HEAD commit.
+ * @return {String} the sha of the HEAD commit.
  */
-function gitHead(execaOpts) {
+function getGitHead(execaOpts) {
   return execa.stdout('git', ['rev-parse', 'HEAD'], execaOpts);
 }
 
@@ -149,16 +149,16 @@ async function tag(tagName, execaOpts) {
  * @throws {Error} if the push failed.
  */
 async function push(repositoryUrl, branch, execaOpts) {
-  await execa('git', ['push', '--tags', repositoryUrl, `HEAD:${branch}`], execaOpts);
+  await execa('git', ['push', '--tags', repositoryUrl], execaOpts);
 }
 
 /**
  * Verify a tag name is a valid Git reference.
  *
- * @param {string} tagName the tag name to verify.
+ * @param {String} tagName the tag name to verify.
  * @param {Object} [execaOpts] Options to pass to `execa`.
  *
- * @return {boolean} `true` if valid, falsy otherwise.
+ * @return {Boolean} `true` if valid, falsy otherwise.
  */
 async function verifyTagName(tagName, execaOpts) {
   try {
@@ -186,11 +186,11 @@ async function isBranchUpToDate(branch, execaOpts) {
 }
 
 module.exports = {
-  gitTagHead,
-  gitTags,
+  getTagHead,
+  getTags,
   isRefInHistory,
   fetch,
-  gitHead,
+  getGitHead,
   repoUrl,
   isGitRepo,
   verifyAuth,

test/cli.test.js

@@ -186,7 +186,7 @@ test.serial('Display help', async t => {
   t.is(exitCode, 0);
 });
 
-test.serial('Returns error code and prints help if called with a command', async t => {
+test.serial('Return error code and prints help if called with a command', async t => {
   const run = stub().resolves(true);
   const argv = ['', '', 'pre'];
   const cli = requireNoCache('../cli', {'.': run, process: {...process, argv}});

test/get-config.test.js

@@ -212,7 +212,7 @@ test('Read configuration from file path in "extends"', async t => {
     branch: 'test_branch',
     repositoryUrl: 'https://host.null/owner/module.git',
     tagFormat: `v\${version}`,
-    plugins: false,
+    plugins: ['plugin-1', ['plugin-2', {plugin2Opt: 'value'}]],
   };
   // Create package.json and shareable.json in repository root
   await outputJson(path.resolve(cwd, 'package.json'), {release: pkgOptions});
@@ -227,6 +227,8 @@ test('Read configuration from file path in "extends"', async t => {
   t.deepEqual(t.context.plugins.args[0][1], {
     analyzeCommits: './shareable.json',
     generateNotes: './shareable.json',
+    'plugin-1': './shareable.json',
+    'plugin-2': './shareable.json',
   });
 });
 

test/git.test.js

@@ -1,14 +1,14 @@
 import test from 'ava';
 import tempy from 'tempy';
 import {
-  gitTagHead,
+  getTagHead,
   isRefInHistory,
   fetch,
-  gitHead,
+  getGitHead,
   repoUrl,
   tag,
   push,
-  gitTags,
+  getTags,
   isGitRepo,
   verifyTagName,
   isBranchUpToDate,
@@ -33,7 +33,7 @@ test('Get the last commit sha', async t => {
   // Add commits to the master branch
   const commits = await gitCommits(['First'], {cwd});
 
-  const result = await gitHead({cwd});
+  const result = await getGitHead({cwd});
 
   t.is(result, commits[0].hash);
 });
@@ -42,7 +42,7 @@ test('Throw error if the last commit sha cannot be found', async t => {
   // Create a git repository, set the current working directory at the root of the repo
   const {cwd} = await gitRepo();
 
-  await t.throws(gitHead({cwd}), Error);
+  await t.throws(getGitHead({cwd}), Error);
 });
 
 test('Unshallow and fetch repository', async t => {
@@ -84,7 +84,7 @@ test('Fetch all tags on a detached head repository', async t => {
 
   await fetch(repositoryUrl, {cwd});
 
-  t.deepEqual((await gitTags({cwd})).sort(), ['v1.0.0', 'v1.0.1', 'v1.1.0'].sort());
+  t.deepEqual((await getTags({cwd})).sort(), ['v1.0.0', 'v1.0.1', 'v1.1.0'].sort());
 });
 
 test('Verify if the commit `sha` is in the direct history of the current branch', async t => {
@@ -111,8 +111,8 @@ test('Get the commit sha for a given tag or falsy if the tag does not exists', a
   // Create the tag corresponding to version 1.0.0
   await gitTagVersion('v1.0.0', undefined, {cwd});
 
-  t.is(await gitTagHead('v1.0.0', {cwd}), commits[0].hash);
-  t.falsy(await gitTagHead('missing_tag', {cwd}));
+  t.is(await getTagHead('v1.0.0', {cwd}), commits[0].hash);
+  t.falsy(await getTagHead('missing_tag', {cwd}));
 });
 
 test('Return git remote repository url from config', async t => {
@@ -151,7 +151,7 @@ test('Add tag on head commit', async t => {
   await t.is(await gitCommitTag(commits[0].hash, {cwd}), 'tag_name');
 });
 
-test('Push tag and commit to remote repository', async t => {
+test('Push tag to remote repository', async t => {
   // Create a git repository with a remote, set the current working directory at the root of the repo
   const {cwd, repositoryUrl} = await gitRepo(true);
   const commits = await gitCommits(['Test commit'], {cwd});
@@ -162,6 +162,20 @@ test('Push tag and commit to remote repository', async t => {
   t.is(await gitRemoteTagHead(repositoryUrl, 'tag_name', {cwd}), commits[0].hash);
 });
 
+test('Push tag to remote repository with remote branch ahaed', async t => {
+  const {cwd, repositoryUrl} = await gitRepo(true);
+  const commits = await gitCommits(['First'], {cwd});
+  await gitPush(repositoryUrl, 'master', {cwd});
+  const tmpRepo = await gitShallowClone(repositoryUrl);
+  await gitCommits(['Second'], {cwd: tmpRepo});
+  await gitPush('origin', 'master', {cwd: tmpRepo});
+
+  await tag('tag_name', {cwd});
+  await push(repositoryUrl, 'master', {cwd});
+
+  t.is(await gitRemoteTagHead(repositoryUrl, 'tag_name', {cwd}), commits[0].hash);
+});
+
 test('Return "true" if in a Git repository', async t => {
   // Create a git repository with a remote, set the current working directory at the root of the repo
   const {cwd} = await gitRepo(true);
@@ -192,7 +206,7 @@ test('Return falsy for invalid tag names', async t => {
 test('Throws error if obtaining the tags fails', async t => {
   const cwd = tempy.directory();
 
-  await t.throws(gitTags({cwd}));
+  await t.throws(getTags({cwd}));
 });
 
 test('Return "true" if repository is up to date', async t => {
@@ -204,19 +218,18 @@ test('Return "true" if repository is up to date', async t => {
 });
 
 test('Return falsy if repository is not up to date', async t => {
-  let {cwd, repositoryUrl} = await gitRepo(true);
-  const repoDir = cwd;
+  const {cwd, repositoryUrl} = await gitRepo(true);
   await gitCommits(['First'], {cwd});
   await gitCommits(['Second'], {cwd});
   await gitPush(repositoryUrl, 'master', {cwd});
 
   t.true(await isBranchUpToDate('master', {cwd}));
 
-  cwd = await gitShallowClone(repositoryUrl);
-  await gitCommits(['Third'], {cwd});
-  await gitPush('origin', 'master', {cwd});
+  const tmpRepo = await gitShallowClone(repositoryUrl);
+  await gitCommits(['Third'], {cwd: tmpRepo});
+  await gitPush('origin', 'master', {cwd: tmpRepo});
 
-  t.falsy(await isBranchUpToDate('master', {cwd: repoDir}));
+  t.falsy(await isBranchUpToDate('master', {cwd}));
 });
 
 test('Return "true" if local repository is ahead', async t => {

test/helpers/git-utils.js

@@ -26,7 +26,7 @@ import getStream from 'get-stream';
 export async function gitRepo(withRemote, branch = 'master') {
   let cwd = tempy.directory();
 
-  await execa('git', ['init'].concat(withRemote ? ['--bare'] : []), {cwd});
+  await execa('git', ['init', ...(withRemote ? ['--bare'] : [])], {cwd});
 
   const repositoryUrl = fileUrl(cwd);
   if (withRemote) {

test/integration.test.js

@@ -6,7 +6,7 @@ import {writeJson, readJson} from 'fs-extra';
 import execa from 'execa';
 import {WritableStreamBuffer} from 'stream-buffers';
 import {SECRET_REPLACEMENT} from '../lib/definitions/constants';
-import {gitHead as getGitHead, gitTagHead, gitRepo, gitCommits, gitRemoteTagHead, gitPush} from './helpers/git-utils';
+import {gitHead, gitTagHead, gitRepo, gitCommits, gitRemoteTagHead, gitPush} from './helpers/git-utils';
 import gitbox from './helpers/gitbox';
 import mockServer from './helpers/mockserver';
 import npmRegistry from './helpers/npm-registry';
@@ -108,12 +108,12 @@ test('Release patch, minor and major versions', async t => {
   let [, releasedVersion, releasedGitHead] = /^version = '(.+)'\s+gitHead = '(.+)'$/.exec(
     (await execa('npm', ['show', packageName, 'version', 'gitHead'], {env: testEnv, cwd})).stdout
   );
-  let gitHead = await getGitHead({cwd});
+  let head = await gitHead({cwd});
   t.is(releasedVersion, version);
-  t.is(releasedGitHead, gitHead);
-  t.is(await gitTagHead(`v${version}`, {cwd}), gitHead);
-  t.is(await gitRemoteTagHead(authUrl, `v${version}`, {cwd}), gitHead);
-  t.log(`+ released ${releasedVersion} with gitHead ${releasedGitHead}`);
+  t.is(releasedGitHead, head);
+  t.is(await gitTagHead(`v${version}`, {cwd}), head);
+  t.is(await gitRemoteTagHead(authUrl, `v${version}`, {cwd}), head);
+  t.log(`+ released ${releasedVersion} with head ${releasedGitHead}`);
 
   await mockServer.verify(verifyMock);
   await mockServer.verify(createReleaseMock);
@@ -150,12 +150,12 @@ test('Release patch, minor and major versions', async t => {
   [, releasedVersion, releasedGitHead] = /^version = '(.+)'\s+gitHead = '(.+)'$/.exec(
     (await execa('npm', ['show', packageName, 'version', 'gitHead'], {env: testEnv, cwd})).stdout
   );
-  gitHead = await getGitHead({cwd});
+  head = await gitHead({cwd});
   t.is(releasedVersion, version);
-  t.is(releasedGitHead, gitHead);
-  t.is(await gitTagHead(`v${version}`, {cwd}), gitHead);
-  t.is(await gitRemoteTagHead(authUrl, `v${version}`, {cwd}), gitHead);
-  t.log(`+ released ${releasedVersion} with gitHead ${releasedGitHead}`);
+  t.is(releasedGitHead, head);
+  t.is(await gitTagHead(`v${version}`, {cwd}), head);
+  t.is(await gitRemoteTagHead(authUrl, `v${version}`, {cwd}), head);
+  t.log(`+ released ${releasedVersion} with head ${releasedGitHead}`);
 
   await mockServer.verify(verifyMock);
   await mockServer.verify(createReleaseMock);
@@ -192,12 +192,12 @@ test('Release patch, minor and major versions', async t => {
   [, releasedVersion, releasedGitHead] = /^version = '(.+)'\s+gitHead = '(.+)'$/.exec(
     (await execa('npm', ['show', packageName, 'version', 'gitHead'], {env: testEnv, cwd})).stdout
   );
-  gitHead = await getGitHead({cwd});
+  head = await gitHead({cwd});
   t.is(releasedVersion, version);
-  t.is(releasedGitHead, gitHead);
-  t.is(await gitTagHead(`v${version}`, {cwd}), gitHead);
-  t.is(await gitRemoteTagHead(authUrl, `v${version}`, {cwd}), gitHead);
-  t.log(`+ released ${releasedVersion} with gitHead ${releasedGitHead}`);
+  t.is(releasedGitHead, head);
+  t.is(await gitTagHead(`v${version}`, {cwd}), head);
+  t.is(await gitRemoteTagHead(authUrl, `v${version}`, {cwd}), head);
+  t.log(`+ released ${releasedVersion} with head ${releasedGitHead}`);
 
   await mockServer.verify(verifyMock);
   await mockServer.verify(createReleaseMock);
@@ -234,12 +234,12 @@ test('Release patch, minor and major versions', async t => {
   [, releasedVersion, releasedGitHead] = /^version = '(.+)'\s+gitHead = '(.+)'$/.exec(
     (await execa('npm', ['show', packageName, 'version', 'gitHead'], {env: testEnv, cwd})).stdout
   );
-  gitHead = await getGitHead({cwd});
+  head = await gitHead({cwd});
   t.is(releasedVersion, version);
-  t.is(releasedGitHead, gitHead);
-  t.is(await gitTagHead(`v${version}`, {cwd}), gitHead);
-  t.is(await gitRemoteTagHead(authUrl, `v${version}`, {cwd}), gitHead);
-  t.log(`+ released ${releasedVersion} with gitHead ${releasedGitHead}`);
+  t.is(releasedGitHead, head);
+  t.is(await gitTagHead(`v${version}`, {cwd}), head);
+  t.is(await gitRemoteTagHead(authUrl, `v${version}`, {cwd}), head);
+  t.log(`+ released ${releasedVersion} with head ${releasedGitHead}`);
 
   await mockServer.verify(verifyMock);
   await mockServer.verify(createReleaseMock);
@@ -388,12 +388,12 @@ test('Allow local releases with "noCi" option', async t => {
     (await execa('npm', ['show', packageName, 'version', 'gitHead'], {env: testEnv, cwd})).stdout
   );
 
-  const gitHead = await getGitHead({cwd});
+  const head = await gitHead({cwd});
   t.is(releasedVersion, version);
-  t.is(releasedGitHead, gitHead);
-  t.is(await gitTagHead(`v${version}`, {cwd}), gitHead);
-  t.is(await gitRemoteTagHead(authUrl, `v${version}`, {cwd}), gitHead);
-  t.log(`+ released ${releasedVersion} with gitHead ${releasedGitHead}`);
+  t.is(releasedGitHead, head);
+  t.is(await gitTagHead(`v${version}`, {cwd}), head);
+  t.is(await gitRemoteTagHead(authUrl, `v${version}`, {cwd}), head);
+  t.log(`+ released ${releasedVersion} with head ${releasedGitHead}`);
 
   await mockServer.verify(verifyMock);
   await mockServer.verify(createReleaseMock);
@@ -442,12 +442,12 @@ test('Pass options via CLI arguments', async t => {
   const [, releasedVersion, releasedGitHead] = /^version = '(.+)'\s+gitHead = '(.+)'$/.exec(
     (await execa('npm', ['show', packageName, 'version', 'gitHead'], {env: testEnv, cwd})).stdout
   );
-  const gitHead = await getGitHead({cwd});
+  const head = await gitHead({cwd});
   t.is(releasedVersion, version);
-  t.is(releasedGitHead, gitHead);
-  t.is(await gitTagHead(`v${version}`, {cwd}), gitHead);
-  t.is(await gitRemoteTagHead(authUrl, `v${version}`, {cwd}), gitHead);
-  t.log(`+ released ${releasedVersion} with gitHead ${releasedGitHead}`);
+  t.is(releasedGitHead, head);
+  t.is(await gitTagHead(`v${version}`, {cwd}), head);
+  t.is(await gitRemoteTagHead(authUrl, `v${version}`, {cwd}), head);
+  t.log(`+ released ${releasedVersion} with head ${releasedGitHead}`);
 });
 
 test('Run via JS API', async t => {
@@ -500,12 +500,12 @@ test('Run via JS API', async t => {
   const [, releasedVersion, releasedGitHead] = /^version = '(.+)'\s+gitHead = '(.+)'$/.exec(
     (await execa('npm', ['show', packageName, 'version', 'gitHead'], {env: testEnv, cwd})).stdout
   );
-  const gitHead = await getGitHead({cwd});
+  const head = await gitHead({cwd});
   t.is(releasedVersion, version);
-  t.is(releasedGitHead, gitHead);
-  t.is(await gitTagHead(`v${version}`, {cwd}), gitHead);
-  t.is(await gitRemoteTagHead(authUrl, `v${version}`, {cwd}), gitHead);
-  t.log(`+ released ${releasedVersion} with gitHead ${releasedGitHead}`);
+  t.is(releasedGitHead, head);
+  t.is(await gitTagHead(`v${version}`, {cwd}), head);
+  t.is(await gitRemoteTagHead(authUrl, `v${version}`, {cwd}), head);
+  t.log(`+ released ${releasedVersion} with head ${releasedGitHead}`);
 
   await mockServer.verify(verifyMock);
   await mockServer.verify(createReleaseMock);

test/verify.test.js

@@ -11,10 +11,16 @@ test('Throw a AggregateError', async t => {
 
   t.is(errors[0].name, 'SemanticReleaseError');
   t.is(errors[0].code, 'ENOREPOURL');
+  t.truthy(errors[0].message);
+  t.truthy(errors[0].details);
   t.is(errors[1].name, 'SemanticReleaseError');
   t.is(errors[1].code, 'EINVALIDTAGFORMAT');
+  t.truthy(errors[1].message);
+  t.truthy(errors[1].details);
   t.is(errors[2].name, 'SemanticReleaseError');
   t.is(errors[2].code, 'ETAGNOVERSION');
+  t.truthy(errors[2].message);
+  t.truthy(errors[2].details);
 });
 
 test('Throw a SemanticReleaseError if does not run on a git repository', async t => {
@@ -25,6 +31,8 @@ test('Throw a SemanticReleaseError if does not run on a git repository', async t
 
   t.is(errors[0].name, 'SemanticReleaseError');
   t.is(errors[0].code, 'ENOGITREPO');
+  t.truthy(errors[0].message);
+  t.truthy(errors[0].details);
 });
 
 test('Throw a SemanticReleaseError if the "tagFormat" is not valid', async t => {
@@ -35,6 +43,8 @@ test('Throw a SemanticReleaseError if the "tagFormat" is not valid', async t =>
 
   t.is(errors[0].name, 'SemanticReleaseError');
   t.is(errors[0].code, 'EINVALIDTAGFORMAT');
+  t.truthy(errors[0].message);
+  t.truthy(errors[0].details);
 });
 
 test('Throw a SemanticReleaseError if the "tagFormat" does not contains the "version" variable', async t => {
@@ -45,6 +55,8 @@ test('Throw a SemanticReleaseError if the "tagFormat" does not contains the "ver
 
   t.is(errors[0].name, 'SemanticReleaseError');
   t.is(errors[0].code, 'ETAGNOVERSION');
+  t.truthy(errors[0].message);
+  t.truthy(errors[0].details);
 });
 
 test('Throw a SemanticReleaseError if the "tagFormat" contains multiple "version" variables', async t => {
@@ -55,6 +67,8 @@ test('Throw a SemanticReleaseError if the "tagFormat" contains multiple "version
 
   t.is(errors[0].name, 'SemanticReleaseError');
   t.is(errors[0].code, 'ETAGNOVERSION');
+  t.truthy(errors[0].message);
+  t.truthy(errors[0].details);
 });
 
 test('Return "true" if all verification pass', async t => {