fix(registry): be better at using the correct registry (relevant for npme)

Closes #53

README.md

@@ -1,16 +1,15 @@
 # semantic-release
 
-
-[![semantic-release](https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg)](https://github.com/semantic-release/semantic-release)
-[![js-standard-style](https://img.shields.io/badge/code%20style-standard-brightgreen.svg?style=flat)](https://github.com/feross/standard)
-[![Join the chat at https://gitter.im/semantic-release/semantic-release](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/semantic-release/semantic-release?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
-
 [![Build Status](https://travis-ci.org/semantic-release/semantic-release.svg?branch=next)](https://travis-ci.org/semantic-release/semantic-release)
 [![Coverage Status](https://coveralls.io/repos/semantic-release/semantic-release/badge.svg?branch=next&service=github)](https://coveralls.io/github/semantic-release/semantic-release?branch=next)
 
 [![Dependency Status](https://david-dm.org/semantic-release/semantic-release/next.svg)](https://david-dm.org/semantic-release/semantic-release/next)
 [![devDependency Status](https://david-dm.org/semantic-release/semantic-release/next/dev-status.svg)](https://david-dm.org/semantic-release/semantic-release/next#info=devDependencies)
 
+[![Join the chat at https://gitter.im/semantic-release/semantic-release](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/semantic-release/semantic-release?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
+[![semantic-release](https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg)](https://github.com/semantic-release/semantic-release)
+[![js-standard-style](https://img.shields.io/badge/code%20style-standard-brightgreen.svg?style=flat)](https://github.com/feross/standard)
+
 `semantic-release` builds upon a set of conventions to give you **fully automated, semver-compliant package publishing**. It's mostly about _commit-messages_, but you can define more _heuristics_.
 
   | Commands | Comment

package.json

@@ -24,7 +24,7 @@
     "@semantic-release/commit-analyzer": "^2.0.0",
     "@semantic-release/condition-travis": "^4.0.0",
     "@semantic-release/error": "^1.0.0",
-    "@semantic-release/last-release-npm": "^1.1.1",
+    "@semantic-release/last-release-npm": "^1.2.1",
     "@semantic-release/release-notes-generator": "^2.0.0",
     "git-head": "^1.2.1",
     "github": "^0.2.4",

src/index.js

@@ -1,5 +1,6 @@
 const { readFileSync, writeFileSync } = require('fs')
 const path = require('path')
+const url = require('url')
 
 const _ = require('lodash')
 const log = require('npmlog')
@@ -24,6 +25,9 @@ const options = _.defaults(
   pkg.release,
   {
     branch: 'master',
+    fallbackTags: {
+      next: 'latest'
+    },
     debug: !env.CI,
     githubToken: env.GH_TOKEN || env.GITHUB_TOKEN,
     githubUrl: env.GH_URL
@@ -42,11 +46,12 @@ npmconf.load({}, (err, conf) => {
       token: env.NPM_TOKEN
     },
     loglevel: conf.get('loglevel'),
-    registry: conf.get('registry'),
+    registry: require('./lib/get-registry')(pkg, conf),
     tag: (pkg.publishConfig || {}).tag || conf.get('tag') || 'latest'
   }
 
-  if (npm.registry[npm.registry.length - 1] !== '/') npm.registry += '/'
+  // normalize trailing slash
+  npm.registry = url.format(url.parse(npm.registry))
 
   log.level = npm.loglevel
 

src/lib/get-registry.js

@@ -0,0 +1,12 @@
+module.exports = function (pkg, conf) {
+  if (pkg.publishConfig && pkg.publishConfig.registry) return pkg.publishConfig.registry
+
+  if (pkg.name[0] !== '@') return conf.get('registry') || 'https://registry.npmjs.org/'
+
+  const scope = pkg.name.split('/')[0]
+  const scopedRegistry = conf.get(`${scope}/registry`)
+
+  if (scopedRegistry) return scopedRegistry
+
+  return conf.get('registry') || 'https://registry.npmjs.org/'
+}

test/specs/get-registry.js

@@ -0,0 +1,30 @@
+const test = require('tap').test
+
+const getRegistry = require('../../dist/lib/get-registry')
+
+test('get correct registry', (t) => {
+  t.is(getRegistry({
+    name: 'publish-config',
+    publishConfig: {
+      registry: 'a'
+    }},
+  {}), 'a')
+
+  t.is(getRegistry({name: 'normal'}, {get: () => 'b'}), 'b')
+
+  t.is(getRegistry({name: 'normal'}, {get: () => null}), 'https://registry.npmjs.org/')
+
+  t.is(getRegistry({name: '@scoped/foo'}, {
+    get: (input) => input === '@scoped/registry' ? 'c' : 'd'
+  }), 'c')
+
+  t.is(getRegistry({name: '@scoped/bar'}, {
+    get: () => 'e'
+  }), 'e')
+
+  t.is(getRegistry({name: '@scoped/baz'}, {
+    get: () => null
+  }), 'https://registry.npmjs.org/')
+
+  t.end()
+})