fix: use spawn instead of exec for 'git log' to avoid maxBuffer err

When `git branch --contains ${commit}` has colored output the `inHistory` check failed

README.md

@@ -77,11 +77,11 @@ This removes the immediate connection between human emotions and version numbers
 
 ## How does it work?
 
-Instead of writing [meaningless commit messages](http://whatthecommit.com/), we can take our time to think about the changes in the codebase and write them down. Following formalized conventions it this then possible to generate a helpful changelog and to derive the next semantic version number from them.
+Instead of writing [meaningless commit messages](http://whatthecommit.com/), we can take our time to think about the changes in the codebase and write them down. Following formalized conventions it is then possible to generate a helpful changelog and to derive the next semantic version number from them.
 
-When `semantic-release` got setup it will do that after every successful continuous integration build of your master branch (or any other branch you specify) and publish the new version for you. That way no human is directly involved in the release process and your releases are guaranteed to be [unromantic and unsentimental](http://sentimentalversioning.org/).
+When `semantic-release` is setup it will do that after every successful continuous integration build of your master branch (or any other branch you specify) and publish the new version for you. This way no human is directly involved in the release process and your releases are guaranteed to be [unromantic and unsentimental](http://sentimentalversioning.org/).
 
-If you fear the loss of control over timing and marketing implications of software releases you should know that `semantic-release` supports [release channels](https://github.com/npm/npm/issues/2718) using `npm`’s [dist-tags](https://docs.npmjs.com/cli/dist-tag). This way you can keep control over what your users end up using by default, you can decide when to promote an automatically released version to the stable channel and you can choose which versions to write blogposts and tweets about. You can use the same mechanism to [support older versions of your software](https://gist.github.com/boennemann/54042374e49c7ade8910), for example with important security fixes.
+If you fear the loss of control over timing and marketing implications of software releases you should know that `semantic-release` supports [release channels](https://github.com/npm/npm/issues/2718) using `npm`’s [dist-tags](https://docs.npmjs.com/cli/dist-tag). This way you can keep control over what your users end up using by default, you can decide when to promote an automatically released version to the stable channel, and you can choose which versions to write blogposts and tweets about. You can use the same mechanism to [support older versions of your software](https://gist.github.com/boennemann/54042374e49c7ade8910), for example with important security fixes.
 
 This is what happens in series:
 
@@ -96,7 +96,7 @@ _Note:_ The current release/tag implementation is tied to GitHub, but could be o
 This module ships with the [AngularJS Commit Message Conventions](https://docs.google.com/document/d/1QrDFcIiPjSLDn3EL15IJygNPiHORgU1_OOAqWjiDU5Y/edit) and changelog generator, but you can [define your own](#plugins) style.
 
 Each commit message consists of a **header**, a **body** and a **footer**.  The header has a special
-format that includes a **type**, a **scope** and a **subject** ([full explanation](https://github.com/ajoslin/conventional-changelog/blob/master/conventions/angular.md)):
+format that includes a **type**, a **scope** and a **subject** ([full explanation](https://github.com/stevemao/conventional-changelog-angular/blob/master/convention.md)):
 
 ```
 <type>(<scope>): <subject>
@@ -141,7 +141,7 @@ semantic-release-cli setup
 
 ![dialogue](https://cloud.githubusercontent.com/assets/908178/9428123/3628dfec-499f-11e5-8bdd-8f3042dd95ed.png)
 
-_[This is what happens under the hood.](https://github.com/semantic-release/cli#manual-setup)_
+_[This is what happens under the hood.](https://github.com/semantic-release/cli#what-it-does)_
 
 ## Options
 
@@ -157,6 +157,7 @@ These options are currently available:
 - `debug`: If true doesn’t actually publish to npm or write things to file. Default: `!process.env.CI`
 - `githubToken`: The token used to authenticate with GitHub. Default: `process.env.GH_TOKEN`
 - `githubUrl`: Optional. Pass your GitHub Enterprise endpoint.
+- `githubApiPathPrefix`: Optional. The path prefix for your GitHub Enterprise API.
 
 _A few notes on `npm` config_:
 1. The `npm` token can only be defined in the environment as `NPM_TOKEN`, because that’s where `npm` itself is going to read it from.

bin/semantic-release.js

@@ -13,6 +13,7 @@ var normalizeData = require('normalize-package-data')
 log.heading = 'semantic-release'
 var env = process.env
 var pkg = JSON.parse(fs.readFileSync('./package.json'))
+var originalPkg = _.cloneDeep(pkg)
 normalizeData(pkg)
 var knownOptions = {
   branch: String,
@@ -51,6 +52,7 @@ npmconf.load({}, function (err, conf) {
     auth: {
       token: env.NPM_TOKEN
     },
+    cafile: conf.get('cafile'),
     loglevel: conf.get('loglevel'),
     registry: require('../src/lib/get-registry')(pkg, conf),
     tag: (pkg.publishConfig || {}).tag || conf.get('tag') || 'latest'
@@ -138,7 +140,7 @@ npmconf.load({}, function (err, conf) {
             log.silly('pre', 'Couldn\'t find npm-shrinkwrap.json.')
           }
 
-          fs.writeFileSync('./package.json', JSON.stringify(_.assign(pkg, {
+          fs.writeFileSync('./package.json', JSON.stringify(_.assign(originalPkg, {
             version: release.version
           }), null, 2))
 
@@ -158,6 +160,6 @@ npmconf.load({}, function (err, conf) {
       log.verbose('post', (published ? 'Published' : 'Generated') + ' release notes.', release)
     })
   } else {
-    log.error('post', 'Command "' + options.argv.remain[0] + '" not recognized. User either "pre" or "post"')
+    log.error('post', 'Command "' + options.argv.remain[0] + '" not recognized. Use either "pre" or "post"')
   }
 })

package.json

@@ -15,7 +15,7 @@
   "dependencies": {
     "@bahmutov/parse-github-repo-url": "^0.1.0",
     "@semantic-release/commit-analyzer": "^2.0.0",
-    "@semantic-release/condition-travis": "^5.0.0",
+    "@semantic-release/condition-travis": "^5.0.2",
     "@semantic-release/error": "^1.0.0",
     "@semantic-release/last-release-npm": "^1.2.1",
     "@semantic-release/release-notes-generator": "^2.0.0",
@@ -26,9 +26,9 @@
     "nopt": "^3.0.3",
     "normalize-package-data": "^2.3.4",
     "npmconf": "^2.1.2",
-    "npmlog": "^2.0.0",
+    "npmlog": "^4.0.0",
     "require-relative": "^0.8.7",
-    "run-auto": "^1.1.2",
+    "run-auto": "^2.0.0",
     "run-series": "^1.1.3",
     "semver": "^5.0.3"
   },
@@ -36,14 +36,15 @@
     "coveralls": "^2.11.4",
     "cz-conventional-changelog": "^1.1.4",
     "mkdirp": "^0.5.1",
-    "nixt": "^0.4.1",
-    "nock": "^5.2.1",
+    "mock-spawn": "^0.2.6",
+    "nixt": "^0.5.0",
+    "nock": "^8.0.0",
     "npm-registry-couchapp": "^2.6.11",
-    "nyc": "^5.0.0",
+    "nyc": "^7.0.0",
     "proxyquire": "^1.7.3",
     "rimraf": "^2.5.0",
-    "standard": "^5.3.0",
-    "tap": "^5.0.0"
+    "standard": "^7.0.1",
+    "tap": "^6.2.0"
   },
   "engines": {
     "node": ">=0.10",

src/lib/commits.js

@@ -1,4 +1,4 @@
-var exec = require('child_process').exec
+var childProcess = require('child_process')
 
 var log = require('npmlog')
 
@@ -13,7 +13,7 @@ module.exports = function (config, cb) {
 
   if (!from) return extract()
 
-  exec('git branch --contains ' + from, function (err, stdout) {
+  childProcess.exec('git branch --no-color --contains ' + from, function (err, stdout) {
     var inHistory = false
     var branches
 
@@ -47,25 +47,33 @@ module.exports = function (config, cb) {
   })
 
   function extract () {
-    exec(
-      'git log -E --format=%H==SPLIT==%B==END== ' + range,
-      function (err, stdout) {
-        if (err) return cb(err)
+    var child = childProcess.spawn('git', ['log', '-E', '--format=%H==SPLIT==%B==END==', range])
+    var stdout = ''
+    var err = ''
 
-        cb(null, String(stdout).split('==END==\n')
+    child.stdout.on('data', function (data) {
+      stdout += data
+    })
 
+    child.stderr.on('data', function (data) {
+      err += data
+    })
+
+    child.on('close', function (code) {
+      if (err || code) return cb(err)
+
+      cb(null, String(stdout).split('==END==\n')
         .filter(function (raw) {
           return !!raw.trim()
         })
-
         .map(function (raw) {
           var data = raw.split('==SPLIT==')
           return {
             hash: data[0],
             message: data[1]
           }
-        }))
-      }
-    )
+        })
+      )
+    })
   }
 }

src/lib/verify.js

@@ -1,5 +1,3 @@
-var parseSlug = require('@bahmutov/parse-github-repo-url')
-
 var SemanticReleaseError = require('@semantic-release/error')
 
 module.exports = function (config) {
@@ -20,11 +18,6 @@ module.exports = function (config) {
       'No "repository" found in package.json.',
       'ENOPKGREPO'
     ))
-  } else if (!parseSlug(pkg.repository.url)) {
-    errors.push(new SemanticReleaseError(
-      'The "repository" field in the package.json is malformed.',
-      'EMALFORMEDPKGREPO'
-    ))
   }
 
   if (options.debug) return errors

src/post.js

@@ -14,7 +14,8 @@ module.exports = function (config, cb) {
     version: '3.0.0',
     port: ghConfig.port,
     protocol: (ghConfig.protocol || '').split(':')[0] || null,
-    host: ghConfig.hostname
+    host: ghConfig.hostname,
+    pathPrefix: options.githubApiPathPrefix || null
   })
 
   plugins.generateNotes(config, function (err, log) {

src/pre.js

@@ -10,13 +10,13 @@ module.exports = function (config, cb) {
 
   auto({
     lastRelease: plugins.getLastRelease.bind(null, config),
-    commits: ['lastRelease', function (cb, results) {
+    commits: ['lastRelease', function (results, cb) {
       getCommits(_.assign({
         lastRelease: results.lastRelease
       }, config),
       cb)
     }],
-    type: ['commits', 'lastRelease', function (cb, results) {
+    type: ['commits', 'lastRelease', function (results, cb) {
       getType(_.assign({
         commits: results.commits,
         lastRelease: results.lastRelease

test/mocks/child-process.js

@@ -1,21 +1,30 @@
+var mockSpawn = require('mock-spawn')()
+mockSpawn.setStrategy(function (command, args, opts) {
+  return function (cb) {
+    this.stdout.write(
+      /\.\.HEAD/.test(args.join(' '))
+        ? rawCommits[0]
+        : rawCommits.join()
+    )
+    cb(0)
+  }
+})
+
 const rawCommits = [
   'hash-one==SPLIT==commit-one==END==\n',
   'hash-two==SPLIT==commit-two==END==\n'
 ]
 
 module.exports = {
-  exec: function (command, cb) {
+  exec: function (command, options, cb) {
+    if (typeof cb === 'undefined' && typeof options === 'function') {
+      cb = options
+    }
     if (/contains/.test(command)) {
       if (/notinhistory/.test(command)) return cb(new Error())
       return cb(null, 'whatever\nmaster\n')
     }
-
-    cb(
-      null,
-      /\.\.HEAD/.test(command)
-        ? rawCommits[0]
-        : rawCommits.join()
-    )
   },
+  spawn: mockSpawn,
   '@noCallThru': true
 }

test/specs/verify.js

@@ -25,19 +25,6 @@ test('verify pkg, options and env', function (t) {
     tt.is(errors[0].code, 'ENOPKGNAME')
     tt.is(errors[1].code, 'ENOPKGREPO')
 
-    var errors2 = verify({
-      options: {debug: true},
-      pkg: {
-        name: 'package',
-        repository: {
-          url: 'lol'
-        }
-      }
-    })
-
-    tt.is(errors2.length, 1)
-    tt.is(errors2[0].code, 'EMALFORMEDPKGREPO')
-
     tt.end()
   })